Skip to content

Get DefaultTags from appSettings (#319)#320

Merged
niemyjski merged 2 commits into
exceptionless:mainfrom
nmdias:appsettings-tags
Mar 31, 2025
Merged

Get DefaultTags from appSettings (#319)#320
niemyjski merged 2 commits into
exceptionless:mainfrom
nmdias:appsettings-tags

Conversation

@nmdias

@nmdias nmdias commented Mar 28, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@CLAassistant

CLAassistant commented Mar 28, 2025

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@nmdias nmdias changed the title Get tags from appSettings #319 Get tags from appSettings Mar 29, 2025
Comment thread src/Exceptionless/Extensions/ExceptionlessConfigurationExtensions.cs Outdated

@niemyjski niemyjski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for thre PR, it looks good just need to get to concensus on the name of it!

My vote is DefaultTags as that aligns with IConfiguration but open to feedback cc @ejsmith .

@niemyjski niemyjski changed the title Get tags from appSettings Get tags from appSettings (#319) Mar 31, 2025
@niemyjski niemyjski self-assigned this Mar 31, 2025
@nmdias nmdias changed the title Get tags from appSettings (#319) Get DefaultTags from appSettings (#319) Mar 31, 2025
@nmdias

nmdias commented Mar 31, 2025

Copy link
Copy Markdown
Contributor Author

@niemyjski will be possible to get a release with this update? 🙏

@niemyjski

Copy link
Copy Markdown
Member

Yes, I'll get a release out this week. I just wanted to check in on a second issue I'm waiting to hear back on (#318)

@niemyjski niemyjski merged commit b4ffece into exceptionless:main Mar 31, 2025
@nmdias

nmdias commented Mar 31, 2025

Copy link
Copy Markdown
Contributor Author

Super! Thanks :)

@niemyjski

niemyjski commented Apr 7, 2025

Copy link
Copy Markdown
Member

New release is going out https://github.com/exceptionless/Exceptionless.Net/releases/tag/v6.1.0 , Thanks again

@nmdias

nmdias commented Apr 7, 2025

Copy link
Copy Markdown
Contributor Author

Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants