[ios][precompile] change to angled include in umbrella #54840
Closed
+294
−288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
added
p: Expo
Job Summary for GradleTest All :: run_fantom_tests
|
cipolleschi
approved these changes
Dec 10, 2025
cipolleschi
changed the base branch from
main
to
chrfalch/react-precompile-move-header-template-to-separate-folder
cipolleschi
approved these changes
Dec 16, 2025
This was referenced Dec 17, 2025
cipolleschi
changed the base branch from
chrfalch/react-precompile-move-header-template-to-separate-folder
to
main
A small cleanup to make the directory structure of the header file template when building xcframeworks. Umbrella and module map templates are now moved into templates folder.
chrfalch
force-pushed
the
chrfalch/react-precompile-change-to-angled-include-in-umbrella
branch
2 times, most recently
from
fb5975f to
a91c7bb
Compare
To make the later VFS overlays work, our React umbrella header needs to use angled import syntax instead of quoted". This is so that the compiler will look up by module and not only by path.
chrfalch
force-pushed
the
chrfalch/react-precompile-change-to-angled-include-in-umbrella
branch
from
a91c7bb to
0b0199e
Compare
chrfalch
changed the base branch from
main
to
chrfalch/react-precompile-move-header-template-to-separate-folder
chrfalch
changed the base branch from
chrfalch/react-precompile-move-header-template-to-separate-folder
to
main
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D89377015. |
cortinico
approved these changes
Jan 14, 2026
Contributor
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
meta-codesync bot
pushed a commit
that referenced
this pull request
Jan 14, 2026
Summary: A small cleanup to make the directory structure of the header file template when building xcframeworks. Umbrella and module map templates are now moved into a templates folder in the scripts/iOS-prebuilt folder Prev PR: #54838 Next PR: #54840 ## Changelog: [INTERNAL] [FIXED] - Moved iOS prebuild scripts to templates folder. Pull Request resolved: #54839 Test Plan: Run RNTester with prebuilds Reviewed By: cortinico Differential Revision: D89376964 Pulled By: cipolleschi fbshipit-source-id: d3c5cdb1dda8c30df563b57533b40efbf29ff67e
|
@cipolleschi merged this pull request in 2b66a9a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
To make the later VFS overlays work, our React umbrella header needs to use angled import syntax instead of quoted".
This is so that the compiler will look up by module and not only by path.
Prev PR: #54839
Next PR: #54841
Changelog:
[IOS] [FIXED] - changed umbrella header template to use angled import syntax
Test Plan:
Run RNTester with prebuilds