Skip to content

fix(android): replace std::format with std::to_string in graphicsConversions.h for C++17 compatibility #55112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shubhamd99 wants to merge 1 commit into from
Closed

fix(android): replace std::format with std::to_string in graphicsConversions.h for C++17 compatibility #55112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/react-native/ReactCommon/react/renderer/core/graphicsConversions.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

#include <array>
#include <unordered_map>
#include <string>

#include <glog/logging.h>
#include <react/debug/react_native_expect.h>
Expand Down Expand Up @@ -68,7 +69,7 @@ inline folly::dynamic toDynamic(const YGValue &dimension)
case YGUnitPoint:
return dimension.value;
case YGUnitPercent:
return std::format("{}%", dimension.value);
return std::to_string(dimension.value) + "%";
}

return nullptr;
Expand Down