Remove shouldUseLinkRoleForPressableText feature flag #55121
+165
−530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Changelog: [Android][Fixed] - Reset OnClickListener to null when recycling views to avoid accessibility tools finding views with incorrect state --- This diff removes the `shouldResetOnClickListenerWhenRecyclingView` feature flag since it has been tested in FB4A for a month with `defaultValue: true`. The flag was introduced to reset `OnClickListener` to null when recycling views on Android to avoid accessibility tools finding views with incorrect state after recycling. This behavior is now the default. Changes: - Removed the flag definition from `ReactNativeFeatureFlags.config.js` - Removed the conditional check in `BaseViewManager.java`, now `view.setOnClickListener(null)` is always called unconditionally - Removed the override from `ReactNativeFeatureFlagsOverrides_Facebook_Android.kt` - Regenerated all feature flag files via `js1 featureflags --update` Differential Revision: D90384358
Summary:
Changelog: [Android][Fixed] - Properly set view.setEnabled() based on accessibilityState.disabled
---
This diff removes the `shouldSetEnabledBasedOnAccessibilityState` feature flag since it has been tested in FB4A for a month with `defaultValue: true`.
The flag was introduced to fix `BaseViewManager` to properly set `view.setEnabled()` based on `accessibilityState.disabled`. Previously, the old behavior only set `enabled(true)` when `disabled=false`, but didn't set `enabled(false)` when `disabled=true`. The new behavior properly sets the enabled state for both cases. This behavior is now the default.
Changes:
- Removed the flag definition from `ReactNativeFeatureFlags.config.js`
- Removed the conditional check in `BaseViewManager.java`, now `view.setEnabled(!accessibilityState.getBoolean("disabled"))` is always called unconditionally
- Removed the override from `ReactNativeFeatureFlagsOverrides_Facebook_Android.kt`
- Regenerated all feature flag files via `js1 featureflags --update`
Differential Revision: D90384878
Summary: Changelog: [Android][Fixed] - Set accessibilityRole to "link" for pressable Text components by default --- This diff removes the `shouldUseLinkRoleForPressableText` feature flag since it has been tested in FB4A for a month with `defaultValue: true`. The flag was introduced to automatically set `accessibilityRole="link"` for pressable Text components by default. This behavior is now the default. Changes: - Removed the flag definition from `ReactNativeFeatureFlags.config.js` - Removed the conditional checks in `Text.js` (2 locations), now `shouldUseLinkRole` is computed directly without the feature flag - Removed the override from `ReactNativeFeatureFlagsOverrides_Facebook.js` - Updated tests in `Text-test.js` to remove flag mocking and only test the enabled behavior - Regenerated all feature flag files via `js1 featureflags --update` Reviewed By: javache Differential Revision: D90385104
meta-cla
bot
added
the
CLA Signed
|
@fabriziocucci has exported this pull request. If you are a Meta employee, you can view the originating Diff in D90385104. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Android][Fixed] - Set accessibilityRole to "link" for pressable Text components by default
This diff removes the
shouldUseLinkRoleForPressableTextfeature flag since it has been tested in FB4A for a month withdefaultValue: true.The flag was introduced to automatically set
accessibilityRole="link"for pressable Text components by default. This behavior is now the default.Changes:
ReactNativeFeatureFlags.config.jsText.js(2 locations), nowshouldUseLinkRoleis computed directly without the feature flagReactNativeFeatureFlagsOverrides_Facebook.jsText-test.jsto remove flag mocking and only test the enabled behaviorjs1 featureflags --updateReviewed By: javache
Differential Revision: D90385104