Inline onTransitionAnimationEnd and fix iterator invalidation in ViewTransitionModule#56104
Closed
zeyap wants to merge 1 commit intofacebook:mainfrom
Closed
Inline onTransitionAnimationEnd and fix iterator invalidation in ViewTransitionModule#56104zeyap wants to merge 1 commit intofacebook:mainfrom
zeyap wants to merge 1 commit intofacebook:mainfrom
Conversation
…TransitionModule Summary: `startViewTransitionEnd` was removing entries from `nameRegistry_` while iterating over it via `onTransitionAnimationEnd`, which is undefined behavior. This diff improves the fix by: - Inlining `onTransitionAnimationEnd` (private, single call site) - Clearing `nameRegistry_` after the loop instead of erasing during iteration, removing the need for a copy ## Changelog: [Internal] [Fixed] - Inline onTransitionAnimationEnd and fix iterator invalidation in ViewTransitionModule Reviewed By: christophpurrer Differential Revision: D96085815
meta-cla
bot
added
the
CLA Signed
Collaborator
|
This pull request was successfully merged by @zeyap in 670d769 When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in 670d769. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
startViewTransitionEndwas removing entries fromnameRegistry_while iterating over it viaonTransitionAnimationEnd, which is undefined behavior.This diff improves the fix by:
onTransitionAnimationEnd(private, single call site)nameRegistry_after the loop instead of erasing during iteration, removing the need for a copyChangelog:
[Internal] [Fixed] - Inline onTransitionAnimationEnd and fix iterator invalidation in ViewTransitionModule
Reviewed By: christophpurrer
Differential Revision: D96085815