[General] [Fixed] - Fix hover out timeout stored in wrong variable in Pressability#56328
Open
w3di wants to merge 1 commit intofacebook:mainfrom
Open
[General] [Fixed] - Fix hover out timeout stored in wrong variable in Pressability#56328w3di wants to merge 1 commit intofacebook:mainfrom
w3di wants to merge 1 commit intofacebook:mainfrom
Conversation
… Pressability The onMouseLeave handler incorrectly assigned the delayed onHoverOut timeout to _hoverInDelayTimeout instead of _hoverOutDelayTimeout. This caused _cancelHoverOutDelayTimeout() to not cancel the pending onHoverOut callback, and _cancelHoverInDelayTimeout() to incorrectly cancel it instead.
meta-cla
bot
added
the
CLA Signed
facebook-github-tools
bot
added
the
Shared with Meta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
onMouseLeavehandler inPressabilitystores the delayedonHoverOuttimeout in_hoverInDelayTimeoutinstead of_hoverOutDelayTimeout. This is a copy-paste error from theonMouseEnterhandler above it.The Pointer Events path (
onPointerLeave, line 593) correctly uses_hoverOutDelayTimeout. The Mouse Events path (onMouseLeave, line 645) incorrectly uses_hoverInDelayTimeout.This causes:
_cancelHoverOutDelayTimeout()to not cancel the pendingonHoverOutcallback_cancelHoverInDelayTimeout()to incorrectly cancelonHoverOutinstead ofonHoverInonHoverIntimeout to be silently overwritten if it existsAffects non-mobile platforms (web, desktop) when
delayHoverOut > 0.Changelog:
[General] [Fixed] - Fix hover out timeout stored in wrong variable in Pressability
Test Plan
yarn jest packages/react-native/Libraries/Pressability/__tests__/Pressability-test.js_hoverOutDelayTimeout, the Mouse Events path (line 645) now matches.