Remove enableFabricRenderer() overrides from downstream consumers (#56896)#56896
Closed
mdvacca wants to merge 1 commit into
Closed
Remove enableFabricRenderer() overrides from downstream consumers (#56896)#56896mdvacca wants to merge 1 commit into
mdvacca wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@mdvacca has exported this pull request. If you are a Meta employee, you can view the originating Diff in D105347594. |
meta-codesync
Bot
changed the title
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
May 19, 2026
…cebook#56896) Summary: The `enableFabricRenderer()` virtual method is being removed from `ReactNativeFeatureFlagsDefaults`. This diff removes the now-stale `enableFabricRenderer() override` methods from downstream `ReactNativeFeatureFlagsDefaults` subclasses so they compile cleanly once the parent method is gone. Also removes the now-unused `enableFabric` parameter from `createFBReactModuleDefaultsFeatureFlagsProvider` and its single caller. Behavior is unchanged because every override returned `true` (the value the runtime always took at this point) and no other code path depends on the flag. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D105347594
mdvacca
force-pushed
the
export-D105347594
branch
from
320a7f2 to
376d252
Compare
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
May 19, 2026
…cebook#56896) Summary: The `enableFabricRenderer()` virtual method is being removed from `ReactNativeFeatureFlagsDefaults`. This diff removes the now-stale `enableFabricRenderer() override` methods from downstream `ReactNativeFeatureFlagsDefaults` subclasses so they compile cleanly once the parent method is gone. Also removes the now-unused `enableFabric` parameter from `createFBReactModuleDefaultsFeatureFlagsProvider` and its single caller. Behavior is unchanged because every override returned `true` (the value the runtime always took at this point) and no other code path depends on the flag. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D105347594
mdvacca
force-pushed
the
export-D105347594
branch
from
376d252 to
a5905a5
Compare
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
May 19, 2026
…cebook#56896) Summary: The `enableFabricRenderer()` virtual method is being removed from `ReactNativeFeatureFlagsDefaults`. This diff removes the now-stale `enableFabricRenderer() override` methods from downstream `ReactNativeFeatureFlagsDefaults` subclasses so they compile cleanly once the parent method is gone. Also removes the now-unused `enableFabric` parameter from `createFBReactModuleDefaultsFeatureFlagsProvider` and its single caller. Behavior is unchanged because every override returned `true` (the value the runtime always took at this point) and no other code path depends on the flag. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D105347594
mdvacca
force-pushed
the
export-D105347594
branch
from
a5905a5 to
4e862ef
Compare
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
May 19, 2026
…cebook#56896) Summary: The `enableFabricRenderer()` virtual method is being removed from `ReactNativeFeatureFlagsDefaults`. This diff removes the now-stale `enableFabricRenderer() override` methods from downstream `ReactNativeFeatureFlagsDefaults` subclasses so they compile cleanly once the parent method is gone. Also removes the now-unused `enableFabric` parameter from `createFBReactModuleDefaultsFeatureFlagsProvider` and its single caller. Behavior is unchanged because every override returned `true` (the value the runtime always took at this point) and no other code path depends on the flag. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D105347594
mdvacca
force-pushed
the
export-D105347594
branch
from
4e862ef to
8ae98ab
Compare
…cebook#56896) Summary: The `enableFabricRenderer()` virtual method is being removed from `ReactNativeFeatureFlagsDefaults`. This diff removes the now-stale `enableFabricRenderer() override` methods from downstream `ReactNativeFeatureFlagsDefaults` subclasses so they compile cleanly once the parent method is gone. Also removes the now-unused `enableFabric` parameter from `createFBReactModuleDefaultsFeatureFlagsProvider` and its single caller. Behavior is unchanged because every override returned `true` (the value the runtime always took at this point) and no other code path depends on the flag. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D105347594
mdvacca
force-pushed
the
export-D105347594
branch
from
8ae98ab to
b94c214
Compare
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
May 21, 2026
…cebook#56896) Summary: The `enableFabricRenderer()` virtual method is being removed from `ReactNativeFeatureFlagsDefaults`. This diff removes the now-stale `enableFabricRenderer() override` methods from downstream `ReactNativeFeatureFlagsDefaults` subclasses so they compile cleanly once the parent method is gone. Also removes the now-unused `enableFabric` parameter from `createFBReactModuleDefaultsFeatureFlagsProvider` and its single caller. Behavior is unchanged because every override returned `true` (the value the runtime always took at this point) and no other code path depends on the flag. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D105347594
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
May 21, 2026
…cebook#56896) Summary: The `enableFabricRenderer()` virtual method is being removed from `ReactNativeFeatureFlagsDefaults`. This diff removes the now-stale `enableFabricRenderer() override` methods from downstream `ReactNativeFeatureFlagsDefaults` subclasses so they compile cleanly once the parent method is gone. Also removes the now-unused `enableFabric` parameter from `createFBReactModuleDefaultsFeatureFlagsProvider` and its single caller. Behavior is unchanged because every override returned `true` (the value the runtime always took at this point) and no other code path depends on the flag. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D105347594
|
This pull request has been merged in 183e04a. |
Collaborator
|
This pull request was successfully merged by @mdvacca in 183e04a When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The
enableFabricRenderer()virtual method is being removed fromReactNativeFeatureFlagsDefaults. This diff removes the now-staleenableFabricRenderer() overridemethods from downstreamReactNativeFeatureFlagsDefaultssubclasses so they compile cleanly once the parent method is gone.Also removes the now-unused
enableFabricparameter fromcreateFBReactModuleDefaultsFeatureFlagsProviderand its single caller.Behavior is unchanged because every override returned
true(the value the runtime always took at this point) and no other code path depends on the flag.Changelog:
[Internal]
Reviewed By: christophpurrer
Differential Revision: D105347594