Fix percentage-based border radius (#56915)#56915
Closed
j-piasecki wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D105926696. |
facebook-github-tools
Bot
added
p: Software Mansion
Summary: Changelog: [IOS][FIXED] Fixed percentage-based border radius `isUniform` checks if all corners are equal, which is fine in most cases. When it comes to setting broderRadius, it also needs to be checked whether the corner is circular or not. Reviewed By: javache Differential Revision: D105926696
meta-codesync
Bot
changed the title
j-piasecki
force-pushed
the
export-D105926696
branch
from
8a808ae to
3396632
Compare
Collaborator
|
This pull request was successfully merged by @j-piasecki in b496612 When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in b496612. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [IOS][FIXED] Fixed percentage-based border radius
isUniformchecks if all corners are equal, which is fine in most cases. When it comes to setting broderRadius, it also needs to be checked whether the corner is circular or not.Reviewed By: javache
Differential Revision: D105926696