Skip to content

Remove unnecessary HERMES_V1_ENABLED=1 inside build.gradle#56917

Closed
cortinico wants to merge 1 commit into
mainfrom
nc/remove-HERMES_V1_ENABLED=1
Closed

Remove unnecessary HERMES_V1_ENABLED=1 inside build.gradle#56917
cortinico wants to merge 1 commit into
mainfrom
nc/remove-HERMES_V1_ENABLED=1

Conversation

@cortinico
Copy link
Copy Markdown
Contributor

Summary:

This is no longer necessary and just creates a warning:

C/C++: CMake Warning:
C/C++:   Manually-specified variables were not used by the project:
C/C++:     HERMES_V1_ENABLED

Let's clean this up.

Changelog:

[INTERNAL] -

Test Plan:

CI

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 21, 2026
@meta-codesync
Copy link
Copy Markdown

meta-codesync Bot commented May 21, 2026

@cortinico has imported this pull request. If you are a Meta employee, you can view this in D105946805.

@meta-codesync meta-codesync Bot closed this in 5c937d7 May 21, 2026
@facebook-github-tools facebook-github-tools Bot added the Merged This PR has been merged. label May 21, 2026
@meta-codesync
Copy link
Copy Markdown

meta-codesync Bot commented May 21, 2026

@cortinico merged this pull request in 5c937d7.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @cortinico in 5c937d7

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants