Use dispatch_semaphore for eager-main-queue module setup gate#56932
Open
javache wants to merge 1 commit into
Open
Use dispatch_semaphore for eager-main-queue module setup gate#56932javache wants to merge 1 commit into
javache wants to merge 1 commit into
Conversation
Summary: Replace the `std::mutex` + `std::condition_variable` + `std::shared_ptr<bool>` trio that gates the JS thread on main-queue module construction with a single `dispatch_semaphore_t`. The wait block is invoked exactly once (from `_loadScriptFromSource:`'s `beforeLoad` lambda), so single-shot semaphore semantics fit the contract directly — no condition predicate, no shared state captured by three independent `shared_ptr`s. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D105953979
meta-cla
Bot
added
the
CLA Signed
|
@javache has exported this pull request. If you are a Meta employee, you can view the originating Diff in D105953979. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Replace the
std::mutex+std::condition_variable+std::shared_ptr<bool>trio that gates the JS thread on main-queue module construction with a single
dispatch_semaphore_t. The wait block is invoked exactly once (from_loadScriptFromSource:'sbeforeLoadlambda), so single-shot semaphoresemantics fit the contract directly — no condition predicate, no shared state
captured by three independent
shared_ptrs.Changelog: [Internal]
Reviewed By: sammy-SC
Differential Revision: D105953979