Remove 6 empty Objective-C stub headers (#56949)#56949
Open
christophpurrer wants to merge 2 commits into
Open
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D106162524. |
Summary: This removes old bridge-based architecture code that was conditionally compiled via the RCT_REMOVE_LEGACY_ARCH preprocessor flag. The #ifndef RCT_REMOVE_LEGACY_ARCH guards and the legacy code within them have been removed. Where #else branches existed (new architecture code paths), only the new architecture code is kept. Files deleted entirely (100% legacy content): - RCTImageViewManager.mm/h - RCTImageShadowView.mm/h - RCTImageView.mm/h - RCTInputAccessoryViewManager.mm - RCTSinglelineTextInputView.mm/h - RCTSinglelineTextInputViewManager.mm/h - RCTBaseTextShadowView.h Files modified (legacy blocks removed): - RCTReactNativeFactory.mm - removed 5 legacy blocks - RCTAppSetupUtils.mm - removed 2 legacy blocks (functions now return nullptr) Differential Revision: D104495793
Summary: Pull Request resolved: facebook#56949 No behavior change — these headers contributed no symbols and the test exercised a deleted class. Changelog: [iOS][Removed] - Removed six empty Objective-C stub headers (`RCTJSIExecutorRuntimeInstaller.h`, `RCTRootContentView.h`, `RCTRootViewInternal.h`, `RCTNativeModule.h`, `RCTModalManager.h`, `RCTTextAttributes.h`) and the dead `RCTTextAttributesTest`. Differential Revision: D106162524
meta-codesync
Bot
changed the title
christophpurrer
force-pushed
the
export-D106162524
branch
from
17ae688 to
feb3cf2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
No behavior change — these headers contributed no symbols and the test exercised a deleted class.
Changelog:
[iOS][Removed] - Removed six empty Objective-C stub headers (
RCTJSIExecutorRuntimeInstaller.h,RCTRootContentView.h,RCTRootViewInternal.h,RCTNativeModule.h,RCTModalManager.h,RCTTextAttributes.h) and the deadRCTTextAttributesTest.Differential Revision: D106162524