Entangle Gesture revert commit with the corresponding Action commit #35487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of keeping track of which gestures to stop during the next commit, we instead track on the pending gesture whether that gesture should commit that lane next time we get there in the React commit sequence.
When completing a root we can apply the gesture which starts the animation but it's not committed. We mark the lane as suspended at that point.
This will rerender the gesture lane and then commit it which stops the gesture. After that any Transitions can be applied on top.
…commits This part doesn't animate until we release.
github-actions
bot
added
the
React Core Team
sebmarkbage
commented
Jan 12, 2026
| // so that we commit them all together. | ||
| if (gesture.revertLane !== NoLane) { | ||
| const entangledLanes = gesture.revertLane | requestTransitionLane(null); | ||
| markRootEntangled(root, entangledLanes); |
Collaborator
Author
There was a problem hiding this comment.
One thing that's a bit strange with this one is that the revert lane isn't actually scheduled at this point yet because it's not pending until we actually commit the gesture lane which is the one that leaves the work behind. Ideally this should probably be done somewhere in the commit phase instead.
|
Comparing: 5aec1b2...db5f538 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #35486.
When a Gesture commits, it leaves behind work on a Transition lane (
revertLane). This entangles that lane with whatever lane we're using in the event that cancels the Gesture. This ensures that the revert and the result of any resulting Action commits as one batch. Typically the Action would apply a new state that is similar or the same as the revert of the Gesture.This makes it resilient to unbatching in #35392.