Skip to content

[tests] Require exact error messages in assertConsole helpers #35497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rickhanlonii merged 16 commits into from
Jan 13, 2026
Merged

[tests] Require exact error messages in assertConsole helpers #35497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
326cea2
Add full component stacks to console error assertions
rickhanlonii Jan 9, 2026
4cffcc1
fix build test
rickhanlonii Jan 12, 2026
6e8deb0
add internaltestutil changes
rickhanlonii Jan 12, 2026
f87b7d0
Add [Server] and error stack placeholders to console assertions
rickhanlonii Jan 9, 2026
eb04af7
Require exact error messages in assertConsole helpers
rickhanlonii Jan 12, 2026
cc4a2e4
fix test
rickhanlonii Jan 12, 2026
4947b0e
Hack some tests
rickhanlonii Jan 13, 2026
94e85ed
Hack some tests (again)
rickhanlonii Jan 13, 2026
ba9e466
Undo skip for test
rickhanlonii Jan 13, 2026
de514f3
Updates from feedback
rickhanlonii Jan 13, 2026
6917b9e
Oops
rickhanlonii Jan 13, 2026
d15d630
Skip this test
rickhanlonii Jan 13, 2026
f97f160
Don't gate this test
rickhanlonii Jan 13, 2026
9e46955
Don't skip this test (again)
rickhanlonii Jan 13, 2026
8eba132
print node versions
rickhanlonii Jan 13, 2026
e61f352
hell yeah
rickhanlonii Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/runtime_build_and_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,7 @@ jobs:
if: steps.node_modules.outputs.cache-hit != 'true'
- run: yarn --cwd compiler install --frozen-lockfile
if: steps.node_modules.outputs.cache-hit != 'true'
- run: node --version
- run: yarn test ${{ matrix.params }} --ci --shard=${{ matrix.shard }}

# Hardcoded to improve parallelism
Expand Down Expand Up @@ -445,6 +446,7 @@ jobs:
merge-multiple: true
- name: Display structure of build
run: ls -R build
- run: node --version
- run: yarn test --build ${{ matrix.test_params }} --shard=${{ matrix.shard }} --ci

test_build_devtools:
Expand Down Expand Up @@ -489,6 +491,7 @@ jobs:
merge-multiple: true
- name: Display structure of build
run: ls -R build
- run: node --version
- run: yarn test --build --project=devtools -r=experimental --shard=${{ matrix.shard }} --ci

process_artifacts_combined:
Expand Down
Loading
Loading