Fix Result.trace: capture traceback at the exception site#361
Open
thatch wants to merge 1 commit into
Open
Conversation
sys.exc_info() always returned (None, None, None) inside __attrs_post_init__ because the except clause had already exited by the time Result was constructed. Move traceback capture to each except block in api.py using e.__traceback__, and remove the now-dead __attrs_post_init__ from Result (along with the sys/traceback imports that were only needed for it). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
meta-cla
Bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sys.exc_info() always returned (None, None, None) inside attrs_post_init because the except clause had already exited by the time Result was constructed. Move traceback capture to each except block in api.py using e.traceback, and remove the now-dead attrs_post_init from Result (along with the sys/traceback imports that were only needed for it).