Fix AND→OR guards in SortableImport{Item}.__add__#362
Open
thatch wants to merge 1 commit into
Open
Conversation
Both guards used `and`, so they only raised when *both* fields mismatched simultaneously. `bar as x` + `bar as y` (same name, different asname) and `from os …` + `from sys …` (same sort_key, different stem) silently succeeded. Change to `or` so either mismatch raises. Add three regression tests that target each of the two previously-dead raise sites. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
meta-cla
Bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both guards used
and, so they only raised when both fields mismatched simultaneously.bar as x+bar as y(same name, different asname) andfrom os …+from sys …(same sort_key, different stem) silently succeeded. Change toorso either mismatch raises. Add three regression tests that target each of the two previously-dead raise sites.