Conversation
❌ Deploy Preview for endearing-brigadeiros-63f9d0 failed. Why did it fail? →
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1385 +/- ##
=======================================
Coverage 90.01% 90.01%
=======================================
Files 67 67
Lines 4769 4769
Branches 885 885
=======================================
Hits 4293 4293
Misses 458 458
Partials 18 18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
761c2e7 to
dfac352
Compare
dfac352 to
24eb8e2
Compare
jescalada
left a comment
There was a problem hiding this comment.
Looks good so far! Just wondering if we could look into the config loading issue - although it might be because I tested on v1.19.2 rather than the latest rc...
As for the Docker part, I'll do some more setup testing later so we can refine this 👍🏼
Co-authored-by: Juan Escalada <97265671+jescalada@users.noreply.github.com> Signed-off-by: Tabatha DiDomenico <tabatha@gr-oss.io>
Signed-off-by: Tabatha DiDomenico <tabatha.didomenico@gresearch.co.uk>
|
Love to see this going in for v2 and would also like to know why the preview build is failing. I think we could include some content on loadbalancing. I think the app should loadbalance fine (when using Mongodb) - even if you usually only have one node, knowing that you can deploy a second would enable zero-downtime deployments. I'll raise an issue to check if anyone is actively doing this with their deployment. Edit: I note the comment about MongoDB being required for multi-instance deployments. We could go a little further as Git proxy does use local storage during processing but its ephemeral at the moment and relates to only a single request (doesn't need to persist). That will not change with @fabiovincenzi's caching contribution - it just means the nodes will have different caches (and you may want to latch users to particular nodes where possible to make best use of caches). |
Part of #1325, complements #1335.
Adds a deployment guide covering:
Also adds the deployment page to the docs sidebar.