refactor: improve logging in src/proxy/processors, remove log-related stubs/spies in tests#1448
Open
jescalada wants to merge 6 commits intofinos:mainfrom
Open
refactor: improve logging in src/proxy/processors, remove log-related stubs/spies in tests#1448jescalada wants to merge 6 commits intofinos:mainfrom
src/proxy/processors, remove log-related stubs/spies in tests#1448jescalada wants to merge 6 commits intofinos:mainfrom
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1448 +/- ##
==========================================
- Coverage 90.01% 90.00% -0.02%
==========================================
Files 67 67
Lines 4769 4763 -6
Branches 885 884 -1
==========================================
- Hits 4293 4287 -6
Misses 458 458
Partials 18 18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
re-vlad
reviewed
Mar 11, 2026
| ); | ||
| } else { | ||
| console.log(`refUpdates: ${JSON.stringify(refUpdates, null, 2)}`); | ||
| console.log(`parsePush refUpdates: ${JSON.stringify(refUpdates, null, 2)}`); |
There was a problem hiding this comment.
please consider replacing with step.log so all parsePush diagnostics go into the Push DB
Contributor
Author
There was a problem hiding this comment.
I feel that removing that line entirely might be the best choice as it reveals too much about the internal implementation...
@kriswest Just wondering if you recall the reasoning behind logging the refUpdates, and whether you think it's appropriate to add into the step logs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1281, supersedes #1338
Also improves wording and log handling in general, and fixes log stubs in tests.