-
Notifications
You must be signed in to change notification settings - Fork 1.9k
plugin_proxy: allow metrics type for output plugin proxy #9735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
I have a PR for the fluent-bit-go repo fluent/fluent-bit-go#79 that decodes and uses the metric type. It depends on the PR in this repo for metrics to be allowed to flow to the output plugin. |
Previously, the output plugin proxy supported only logs types as this is the default if no event_type is specified. This allows the metrics type to also be routed to output proxy plugins such as the golang proxy plugin. Signed-off-by: Grace Wehner <[email protected]>
|
Hi @edsiper @leonardo-albertovich @fujimotos @koleini would I be able to get a review on this? |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
Hi @edsiper @leonardo-albertovich @fujimotos @koleini would you be able to review this still? |
|
@gracewehner not that there are errors on the tests that need to be addressed. |
This change allows the fluent-bit metrics type to be routed to output proxy plugins such as the golang proxy plugin.
Currently the
proxy output pluginregistration does not include theout->event_typesetting for what types it accepts:fluent-bit/src/flb_plugin_proxy.c
Lines 364 to 370 in faf7da1
For output plugins that have no value for
event_type, those plugins default to supporting only the logs datatype:fluent-bit/src/flb_output.c
Lines 605 to 607 in faf7da1
The
fluent-bit routerwill enforce datatypes between input and output plugins and drop any data that has the type mismatch:fluent-bit/src/flb_task.c
Lines 435 to 438 in faf7da1
Addresses fluent/fluent-bit-go#75, fluent/fluent-bit-go#77
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
fluent/fluent-bit-docs#1531
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.