-
Notifications
You must be signed in to change notification settings - Fork 159
feat(genui): support functions in prompts and verify rendering #921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
a24693d
4134cb3
f9f9e21
1affaab
cb629b6
fb4a577
9c47110
ab3593a
b7bba17
341789f
6d21e7b
5fe5754
6a4ad57
8aff417
f5c991b
ea68855
c6858ab
fc669bd
f27595c
0520535
c7fd032
0f94f83
47379fe
7bc9578
49d8733
ed852c5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../../../../submodules/a2ui/specification/v0_9/json/common_types.json |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../../../../submodules/a2ui/specification/v0_9/json/server_to_client.json |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -340,9 +340,7 @@ final dateTimeInput = CatalogItem( | |
| { | ||
| "id": "root", | ||
| "component": "DateTimeInput", | ||
| "value": { | ||
| "path": "/myDateTime" | ||
| } | ||
| "value": "2026-05-15" | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why did we need to change this example?
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Because |
||
| } | ||
| ] | ||
| ''', | ||
|
|
@@ -354,7 +352,7 @@ final dateTimeInput = CatalogItem( | |
| "value": { | ||
| "path": "/myDate" | ||
| }, | ||
| "enableTime": false | ||
| "variant": "date" | ||
| } | ||
| ] | ||
| ''', | ||
|
|
@@ -366,7 +364,7 @@ final dateTimeInput = CatalogItem( | |
| "value": { | ||
| "path": "/myTime" | ||
| }, | ||
| "enableDate": false | ||
| "variant": "time" | ||
| } | ||
| ] | ||
| ''', | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff is weird on this file; is this a symlink to a git submodule?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QQ, do we need to modify the test runners to clone this package with submodules recursively, or is that the default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the asset files are symbolic links pointing to the spec schemas inside the
submodules/a2uidirectory to keep from duplicating the schemas in multiple places.When publishing to
pub.devwithdart pub publish, pub automatically resolves the symlinks and bundles the actual file contents, so users of the package will get the actual files and don't need to check out the submodules.For CI testing, the test runners in
flutter_packages.yamlare already configured to checkout and update submodules recursively (submodules: recursive), so they are there during testing and validation.