-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Update Google Fonts to v8.0.0 with new and removed fonts #10785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
`dart generator/generator.dart` adds support for numerous new fonts and removed several deprecated or replaced fonts. This corresponds to directory 11, generated in September 2025.
two fonts, Roboto and Saira, offer multiple width variants, exclude those for now and default to the right variant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Google Fonts package to version 8.0.0, introducing a variety of new fonts while removing some deprecated ones. The changes primarily involve auto-generated files resulting from the font update. Additionally, the generator script has been modified to enhance the diff output format and to implement a more sophisticated font deduplication logic that now considers font widths. My review includes a couple of suggestions to improve the maintainability and performance of the generator script.
| @@ -1,3 +1,30 @@ | |||
| ## 8.0.0 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It feels unfortunate to introduce another breaking release so soon after 7.0.0. Is there any opportunity to not remove the two fonts and keep them around, maybe in a deprecated state for a while?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would lean towards not since it's not worth the additional tech debt. At the same time, we've been adhering to the convention that any font removal results in a major version bump. Also, I've gotten confirmation from the fonts team that they'll generate this quarterly, so we could consider this one exceptionally 2 months early (should land the woff2 update first) how does that sound?
| /// | ||
| /// See: | ||
| /// * https://fonts.google.com/specimen/Amarna | ||
| static TextStyle amarna({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kind of weird, Github seems to have dropped syntax highlighting.. selectively.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL syntax highlighting is limited to ~512 KB
dart generator/generator.dartadds support for numerous new fonts and removed several deprecated or replaced fonts. This corresponds to directory 12, generated in January 2026 (generated quarterly from now on).Updated the diff generator to match the current
CHANGELOG.mdformat.More duplicates were identified when initially generating. After investigation, I found that 2 fonts were producing combinations with multiple widths. This PR modifies
_deduplicateFontsto remove these non-standard width (100) variants.Fixes flutter/flutter#180333