Skip to content

Conversation

@guidezpl
Copy link
Member

@guidezpl guidezpl commented Jan 13, 2026

dart generator/generator.dart adds support for numerous new fonts and removed several deprecated or replaced fonts. This corresponds to directory 12, generated in January 2026 (generated quarterly from now on).

Updated the diff generator to match the current CHANGELOG.md format.

More duplicates were identified when initially generating. After investigation, I found that 2 fonts were producing combinations with multiple widths. This PR modifies _deduplicateFonts to remove these non-standard width (100) variants.

Fixes flutter/flutter#180333

`dart generator/generator.dart` adds support for numerous new fonts and removed several deprecated or replaced fonts. This corresponds to directory 11, generated in September 2025.
@github-actions github-actions bot added p: google_fonts triage-framework Should be looked at in framework triage labels Jan 13, 2026
two fonts, Roboto and Saira, offer multiple width variants, exclude those for now and default to the right variant
@guidezpl guidezpl marked this pull request as ready for review January 14, 2026 10:39
@guidezpl guidezpl requested a review from Piinks as a code owner January 14, 2026 10:39
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Google Fonts package to version 8.0.0, introducing a variety of new fonts while removing some deprecated ones. The changes primarily involve auto-generated files resulting from the font update. Additionally, the generator script has been modified to enhance the diff output format and to implement a more sophisticated font deduplication logic that now considers font widths. My review includes a couple of suggestions to improve the maintainability and performance of the generator script.

@@ -1,3 +1,30 @@
## 8.0.0
Copy link
Contributor

@Piinks Piinks Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels unfortunate to introduce another breaking release so soon after 7.0.0. Is there any opportunity to not remove the two fonts and keep them around, maybe in a deprecated state for a while?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would lean towards not since it's not worth the additional tech debt. At the same time, we've been adhering to the convention that any font removal results in a major version bump. Also, I've gotten confirmation from the fonts team that they'll generate this quarterly, so we could consider this one exceptionally 2 months early (should land the woff2 update first) how does that sound?

///
/// See:
/// * https://fonts.google.com/specimen/Amarna
static TextStyle amarna({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind of weird, Github seems to have dropped syntax highlighting.. selectively.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL syntax highlighting is limited to ~512 KB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p: google_fonts triage-framework Should be looked at in framework triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing Momo Trust Display font

2 participants