[go_router] Batch release#11813
Merged
Merged
Conversation
github-actions
Bot
added
p: go_router
triage-framework
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the go_router package to version 17.3.0, raising the minimum supported SDK version to Flutter 3.38/Dart 3.10 and adding the hasOverriddenOnExit parameter to the GoRouteData.$route and RelativeGoRouteData.$route helper methods. There are no review comments, and I have no feedback to provide.
Contributor
|
@chunhtai should this land by itself? Looks like it ran into an issue with repo checks. |
Contributor
|
looks like the ci treated this pr as if it is landing into main. will have to fix this a bit |
Contributor
|
I am going to manually merge this since this is going into release branch and the ci is false positive. will fix the ci later |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was created automatically to batch release the
go_router.