Skip to content

[video_player_web] Remove stale package:web tweaks#11820

Open
faheemabbas766 wants to merge 1 commit into
flutter:mainfrom
faheemabbas766:video-player-web-remove-stale-web-tweaks
Open

[video_player_web] Remove stale package:web tweaks#11820
faheemabbas766 wants to merge 1 commit into
flutter:mainfrom
faheemabbas766:video-player-web-remove-stale-web-tweaks

Conversation

@faheemabbas766
Copy link
Copy Markdown

Removes stale package:web helper setters for disablePictureInPicture and disableRemotePlayback from video_player_web.

These APIs are available directly from package:web 1.0.0, so this updates the package's minimum supported web version to >=1.0.0 <2.0.0. The controlsList helper is intentionally kept because package:web does not expose it yet.

Fixes flutter/flutter#187430

Tests

dart run script/tool/bin/flutter_plugin_tools.dart analyze --packages video_player_web
dart run script/tool/bin/flutter_plugin_tools.dart test --packages video_player_web
flutter pub downgrade && dart analyze --fatal-infos
flutter test --platform=chrome

Notes

No new tests were added because this removes stale compatibility helpers and preserves the existing runtime calls. Existing package tests and lower-bound analysis pass.

The example/integration_test suite was not run locally because Flutter reported: Web devices are not supported for integration tests yet.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. This PR includes the required pubspec.yaml and CHANGELOG.md updates. No new tests were added because this is a compatibility-helper cleanup; existing tests and lower-bound analysis pass. 2

@flutter-dashboard
Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the minimum supported version of package:web to 1.0.0 in pubspec.yaml and updates the changelog accordingly. It also removes obsolete extension methods and setters from pkg_web_tweaks.dart that are now natively supported in the updated package version. There are no review comments, and I have no feedback to provide.

@stuartmorgan-g stuartmorgan-g added the triage-web Should be looked at in web triage label Jun 2, 2026
@stuartmorgan-g stuartmorgan-g requested a review from mdebbar June 2, 2026 18:33
Copy link
Copy Markdown
Contributor

@mdebbar mdebbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up!

@mdebbar mdebbar added the CICD Run CI/CD label Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD p: video_player platform-web triage-web Should be looked at in web triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[video_player_web] Remove stale package:web compatibility helpers

3 participants