[video_player_web] Remove stale package:web tweaks#11820
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
There was a problem hiding this comment.
Code Review
This pull request updates the minimum supported version of package:web to 1.0.0 in pubspec.yaml and updates the changelog accordingly. It also removes obsolete extension methods and setters from pkg_web_tweaks.dart that are now natively supported in the updated package version. There are no review comments, and I have no feedback to provide.
mdebbar
left a comment
There was a problem hiding this comment.
Thanks for cleaning this up!
Removes stale
package:webhelper setters fordisablePictureInPictureanddisableRemotePlaybackfromvideo_player_web.These APIs are available directly from
package:web1.0.0, so this updates the package's minimum supportedwebversion to>=1.0.0 <2.0.0. ThecontrolsListhelper is intentionally kept becausepackage:webdoes not expose it yet.Fixes flutter/flutter#187430
Tests
Notes
No new tests were added because this removes stale compatibility helpers and preserves the existing runtime calls. Existing package tests and lower-bound analysis pass.
The
example/integration_testsuite was not run locally because Flutter reported:Web devices are not supported for integration tests yet.Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
This PR includes the required
pubspec.yamlandCHANGELOG.mdupdates. No new tests were added because this is a compatibility-helper cleanup; existing tests and lower-bound analysis pass. ↩ ↩2