Skip to content

Fix GuessInput focus persistence using StatefulWidget #13402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
harshyadavDeveloper wants to merge 3 commits into
base: main
Choose a base branch
from
+22 −4
Open

Fix GuessInput focus persistence using StatefulWidget #13402

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
888bdca
Fix GuessInput focus persistence using StatefulWidget
harshyadavDeveloper May 19, 2026
0eca84d
Prevent invalid guess submissions in GuessInput
harshyadavDeveloper May 19, 2026
54a3f36
Merge branch 'main' into fix-guessinput-focus-lifecycle
harshyadavDeveloper May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 22 additions & 4 deletions examples/fwe/birdle/lib/main.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,20 +69,38 @@ class _GamePageState extends State<GamePage> {
// #enddocregion GamePage

// #docregion GuessInput
class GuessInput extends StatelessWidget {
GuessInput({super.key, required this.onSubmitGuess});
class GuessInput extends StatefulWidget {
const GuessInput({super.key, required this.onSubmitGuess});

final void Function(String) onSubmitGuess;

@override
State<GuessInput> createState() => _GuessInputState();
}

class _GuessInputState extends State<GuessInput> {
final TextEditingController _textEditingController = TextEditingController();

final FocusNode _focusNode = FocusNode();

void _onSubmit() {
onSubmitGuess(_textEditingController.text.trim());
_textEditingController.clear();
final text = _textEditingController.text.trim();

if (text.length == 5) {
widget.onSubmitGuess(text);
_textEditingController.clear();
}

_focusNode.requestFocus();
}
Comment on lines 86 to 95
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The _onSubmit method calls onSubmitGuess with the trimmed text without validating its length. Since the Game.guess implementation (via Word.fromString) throws an ArgumentError if the string length is not exactly 5, this will cause the application to crash if a user submits an empty or partially filled input. Adding a length check prevents this crash and allows the user to correct their input before resubmitting.

  void _onSubmit() {
    final text = _textEditingController.text.trim();
    if (text.length == 5) {
      widget.onSubmitGuess(text);
      _textEditingController.clear();
    }
    _focusNode.requestFocus();
  }


@override
void dispose() {
_textEditingController.dispose();
_focusNode.dispose();
super.dispose();
}

@override
Widget build(BuildContext context) {
return Row(
Expand Down
Loading