Update banner content to promote the 26Q2 survey#13453
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the site banner in site.yml to invite users to take the Q2 survey instead of announcing the Flutter 3.44 release. The review feedback suggests improving the HTML link by removing the first-person pronoun 'our' to comply with style guidelines and adding rel="noopener" to the anchor tag for security.
| Watch <a href="https://www.youtube.com/watch?v=I1uIbGh1dGE&t=1s" target="_blank">What's new in Flutter</a> and | ||
| read the <a href="https://blog.flutter.dev/whats-new-in-flutter-3-44-b0cc1ad3c527" target="_blank">blog post</a>. | ||
| Help improve Flutter! | ||
| <a href="https://google.qualtrics.com/jfe/form/SV_3drKjSfjNeLZfq6?Source=Website" target="_blank">Take our Q2 survey</a>. |
There was a problem hiding this comment.
According to the Google Developer Documentation Style Guidelines, first-person pronouns like 'our' should be avoided. Additionally, when using target='_blank', it is a security best practice to include rel='noopener' to prevent reverse tabnabbing. Consider updating the link text to 'Take the Q2 survey' and adding rel='noopener'.
<a href="https://google.qualtrics.com/jfe/form/SV_3drKjSfjNeLZfq6?Source=Website" target="_blank" rel="noopener">Take the Q2 survey</a>.There was a problem hiding this comment.
I do prefer "take the...survey" over "take OUR...survey". For me, it's part of the open source mentality.
|
Staged preview of the updated docs.flutter.dev site (updated for commit 3c97796): https://flutter-docs-prod--docs-pr13453-zanderso-patch-1-4zk8vde4.web.app |
|
I'm approving, but please do make these edits. |
Co-authored-by: Parker Lougheed <parlough@gmail.com>
The survey will run from 6/1 9am PT to 6/12 EOD.
Presubmit checklist
of 80 characters or fewer.