Skip to content

Update banner content to promote the 26Q2 survey#13453

Draft
zanderso wants to merge 2 commits into
mainfrom
zanderso-patch-1
Draft

Update banner content to promote the 26Q2 survey#13453
zanderso wants to merge 2 commits into
mainfrom
zanderso-patch-1

Conversation

@zanderso
Copy link
Copy Markdown
Member

@zanderso zanderso commented Jun 1, 2026

The survey will run from 6/1 9am PT to 6/12 EOD.

Presubmit checklist

  • If you are unwilling, or unable, to sign the CLA, even for a tiny, one-word PR, please file an issue instead of a PR.
  • If this PR is not meant to land until a future stable release, mark it as draft with an explanation.
  • This PR follows the Google Developer Documentation Style Guidelines—for example, it doesn't use i.e. or e.g., and it avoids I and we (first-person pronouns).
  • This PR uses semantic line breaks
    of 80 characters or fewer.

@zanderso zanderso requested review from a team and sfshaza2 as code owners June 1, 2026 15:28
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the site banner in site.yml to invite users to take the Q2 survey instead of announcing the Flutter 3.44 release. The review feedback suggests improving the HTML link by removing the first-person pronoun 'our' to comply with style guidelines and adding rel="noopener" to the anchor tag for security.

Comment thread sites/docs/src/data/site.yml Outdated
Watch <a href="https://www.youtube.com/watch?v=I1uIbGh1dGE&t=1s" target="_blank">What's new in Flutter</a> and
read the <a href="https://blog.flutter.dev/whats-new-in-flutter-3-44-b0cc1ad3c527" target="_blank">blog post</a>.
Help improve Flutter!
<a href="https://google.qualtrics.com/jfe/form/SV_3drKjSfjNeLZfq6?Source=Website" target="_blank">Take our Q2 survey</a>.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

According to the Google Developer Documentation Style Guidelines, first-person pronouns like 'our' should be avoided. Additionally, when using target='_blank', it is a security best practice to include rel='noopener' to prevent reverse tabnabbing. Consider updating the link text to 'Take the Q2 survey' and adding rel='noopener'.

  <a href="https://google.qualtrics.com/jfe/form/SV_3drKjSfjNeLZfq6?Source=Website" target="_blank" rel="noopener">Take the Q2 survey</a>.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do prefer "take the...survey" over "take OUR...survey". For me, it's part of the open source mentality.

@flutter-website-bot
Copy link
Copy Markdown
Collaborator

flutter-website-bot commented Jun 1, 2026

Staged preview of the updated docs.flutter.dev site (updated for commit 3c97796):

https://flutter-docs-prod--docs-pr13453-zanderso-patch-1-4zk8vde4.web.app

Copy link
Copy Markdown
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Feel free to land when ready.

There might be a failed check due to formatter changes, feel free to ignore and merge past it. #13449 fixes it.

Comment thread sites/docs/src/data/site.yml Outdated
@zanderso zanderso marked this pull request as draft June 1, 2026 15:35
@sfshaza2
Copy link
Copy Markdown
Contributor

sfshaza2 commented Jun 1, 2026

I'm approving, but please do make these edits.

Copy link
Copy Markdown
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, with minor fixes

Co-authored-by: Parker Lougheed <parlough@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants