-
Notifications
You must be signed in to change notification settings - Fork 198
Add Drifted condition to HelmRelease
#1367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yozel
wants to merge
1
commit into
fluxcd:main
Choose a base branch
from
yozel:yozel/add-drifted-condition
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+235
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drifted conditionDrifted condition to HelmRelease and log generation
7f9cf56 to
e10328c
Compare
e10328c to
238ebbe
Compare
Drifted condition to HelmRelease and log generationDrifted condition to HelmRelease
238ebbe to
627159a
Compare
matheuscscp
reviewed
Jan 8, 2026
627159a to
c7d9ebf
Compare
Member
|
It would be nice to add a test for when the condition is false |
c7d9ebf to
fb7ed67
Compare
Contributor
Author
I'll add it right now |
fb7ed67 to
0d71cdf
Compare
matheuscscp
approved these changes
Jan 9, 2026
Member
matheuscscp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
stefanprodan
reviewed
Jan 9, 2026
5246c26 to
564292c
Compare
This commit introduces a new Kubernetes condition type "Drifted" to improve observability of Helm release drift detection. Signed-off-by: Yasin Özel <[email protected]>
564292c to
5e52cb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Introduces a new condition type "Drifted" to improve observability of Helm release drift detection.
Fix: #1241