Aborting forever and untriggerd on_failure node when aborting failure caused by UserError #6749
Conversation
Signed-off-by: yuteng <[email protected]>
Signed-off-by: yuteng <[email protected]>
|
Bito Automatic Review Skipped - Draft PR |
0yukali0
changed the title
0yukali0
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6749 +/- ##
==========================================
+ Coverage 58.57% 61.29% +2.71%
==========================================
Files 929 708 -221
Lines 70879 42083 -28796
==========================================
- Hits 41520 25795 -15725
+ Misses 26206 13977 -12229
+ Partials 3153 2311 -842
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@0yukali0 thanks for contributing. Any help you need? |
|
@davidmirror-ops |
| if mutableW.Status.FailedAttempts == maxRetries { | ||
| var err error | ||
| _ = controllerutil.AddFinalizer(mutableW, Finalizer) | ||
| SetDefinitionVersionIfEmpty(mutableW, v1alpha1.LatestWorkflowDefinitionVersion) | ||
|
|
||
| func() { | ||
| t := p.metrics.RawWorkflowTraversalTime.Start(ctx) | ||
| defer func() { | ||
| t.Stop() | ||
| if r := recover(); r != nil { | ||
| stack := debug.Stack() | ||
| err = fmt.Errorf("panic when reconciling workflow, Stack: [%s]", string(stack)) | ||
| logger.Errorf(ctx, err.Error()) | ||
| p.metrics.PanicObserved.Inc(ctx) | ||
| } | ||
| }() | ||
| err = p.workflowExecutor.HandleFlyteWorkflow(ctx, mutableW) | ||
| }() | ||
| if err != nil { | ||
| logger.Errorf(ctx, "Error when trying to reconcile workflow. Error [%v]. Error Type[%v]", | ||
| err, reflect.TypeOf(err)) | ||
| p.metrics.SystemError.Inc(ctx) | ||
| return nil, err | ||
| } |
There was a problem hiding this comment.
Do you mind explain a bit why we need this here?
4 participants
Tracking issue
#6695
Why are the changes needed?
What changes were proposed in this pull request?
How was this patch tested?
Labels
Please add one or more of the following labels to categorize your PR:
This is important to improve the readability of release notes.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link