Skip to content

fix: add allowed extensions props on formik input component #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tomrndom wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix: add allowed extensions props on formik input component #913

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8e200c9
fix: add allowed extensions props on formik input component
tomrndom May 5, 2026
7af1940
fix: replace mui formik upload with uicore component
tomrndom May 6, 2026
595e3c6
fix: adjust mock import on test
tomrndom May 7, 2026
654ddf1
fix: adjust uicore version
tomrndom May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@
"moment": "^2.29.1",
"moment-duration-format": "^2.3.2",
"moment-timezone": "^0.5.33",
"openstack-uicore-foundation": "5.0.18-beta.1",
"openstack-uicore-foundation": "5.0.17",
"p-limit": "^6.1.0",
"path-browserify": "^1.0.1",
"postcss-loader": "^6.2.1",
Expand Down
101 changes: 0 additions & 101 deletions src/components/mui/formik-inputs/mui-formik-upload.js
View file
Open in desktop

This file was deleted.

8 changes: 6 additions & 2 deletions ...obal/page-templates/page-template-popup/modules/page-template-document-download-module.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,12 @@ import PropTypes from "prop-types";
import T from "i18n-react/dist/i18n-react";
import { useField } from "formik";
import { Divider, Grid2, InputLabel } from "@mui/material";
import MuiFormikUpload from "../../../../../components/mui/formik-inputs/mui-formik-upload";
import MuiFormikUpload from "openstack-uicore-foundation/lib/components/mui/formik-inputs/upload";
import MuiFormikTextField from "../../../../../components/mui/formik-inputs/mui-formik-textfield";
import { PAGE_MODULES_DOWNLOAD } from "../../../../../utils/constants";
import {
ALLOWED_INVENTORY_IMAGE_FORMATS,
PAGE_MODULES_DOWNLOAD
} from "../../../../../utils/constants";
import MuiFormikRadioGroup from "../../../../../components/mui/formik-inputs/mui-formik-radio-group";

const DocumentDownloadModule = ({ baseName, index }) => {
Expand Down Expand Up @@ -79,6 +82,7 @@ const DocumentDownloadModule = ({ baseName, index }) => {
id={`document-module-upload-${index}`}
name={buildFieldName("file")}
maxFiles={1}
allowedExtensions={["pdf", ...ALLOWED_INVENTORY_IMAGE_FORMATS]}
/>
</Grid2>
)}
Expand Down
2 changes: 1 addition & 1 deletion ...ages/sponsors-global/page-templates/page-template-popup/page-template-module-form.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jest.mock(
);

jest.mock(
"../../../../components/mui/formik-inputs/mui-formik-upload",
"openstack-uicore-foundation/lib/components/mui/formik-inputs/upload",
() =>
function MockMuiFormikUpload({ name }) {
return <div data-testid={`upload-${name}`}>Upload</div>;
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9056,10 +9056,10 @@ open@^10.0.3:
is-inside-container "^1.0.0"
wsl-utils "^0.1.0"

openstack-uicore-foundation@5.0.18-beta.1:
version "5.0.18-beta.1"
resolved "https://registry.yarnpkg.com/openstack-uicore-foundation/-/openstack-uicore-foundation-5.0.18-beta.1.tgz#f79763d84cbe555c5401e254dbd756675bb52043"
integrity sha512-szrIkY99ljJwowsd3jsbmnOTd7hq3SeOTKCB2FFWu06hQ1FdRwX+vew6uqMTiXrIZt+DJlLaUXnd/bQaXCLqeg==
openstack-uicore-foundation@5.0.17:
version "5.0.17"
resolved "https://registry.yarnpkg.com/openstack-uicore-foundation/-/openstack-uicore-foundation-5.0.17.tgz#1438766e41761789afe6487840cc78139c249fad"
integrity sha512-P8z1Vm8X0as6vMsuwUaNhROkVym1DoBUB6bbIE30i8r24wmNKbkvokb+dtYxFvQ/PN4TuCwXAORw/g2zOsrdJA==

optionator@^0.9.1:
version "0.9.4"
Expand Down
Loading