fix: sort remapping candidates to avoid non deterministic output #343
+6
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a non-determinism issue in remapping generation that was causing contracts to produce different compilation hashes across operating systems (see matter-labs/foundry-zksync#1188).
Problem
fs::read_dirreturns directory entries in an arbitrary order that varies between platforms (e.g., macOS vs Ubuntu). When multiple remapping candidates exist, they get processed and output in different orders depending on the system, leading to inconsistent compilation hashes for the same contracts.Fix
Sort remapping candidates before processing to ensure consistent and reproducible output regardless of the underlying filesystem behavior.