Skip to content

Conversation

@adinauer
Copy link
Member

📜 Description

Check sendDefaultPii before attaching user attributes to logs.

💡 Motivation and Context

Fixes #4973

💚 How did you test it?

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

Semver Impact of This PR

🟡 Minor (new features)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

  • (logs) Check sendDefaultPii before attaching user attributes by adinauer in #5036
  • Allow setting native SDK name in manifest by bitsandfoxes in #5027

Build / dependencies / internal 🔧

Deps

  • Bump JamesIves/github-pages-deploy-action from 4.7.6 to 4.8.0 by dependabot in #5015
  • Update Native SDK to v0.12.3 by github-actions in #5012
  • Bump github/codeql-action from 4.31.8 to 4.31.10 by dependabot in #5032

Other

  • (release) Switch from action-prepare-release to Craft by BYK in #5014

🤖 This preview updates automatically when you update the PR.

@github-actions
Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

### Features

- Check `sendDefaultPii` before attaching user attributes ([#5036](https://github.com/getsentry/sentry-java/pull/5036))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description or adding a skip-changelog label.

Generated by 🚫 dangerJS against 2c5e51e

@github-actions
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 332.67 ms 391.74 ms 59.07 ms
Size 1.58 MiB 2.20 MiB 635.38 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
b77456b 393.26 ms 441.10 ms 47.84 ms
d217708 409.83 ms 474.72 ms 64.89 ms
abf451a 332.82 ms 403.67 ms 70.85 ms
d15471f 286.65 ms 314.68 ms 28.03 ms
ee747ae 382.73 ms 435.41 ms 52.68 ms
fc5ccaf 279.11 ms 353.34 ms 74.23 ms
d5a29b6 298.62 ms 391.78 ms 93.16 ms
1edbdfa 364.77 ms 450.29 ms 85.52 ms
d15471f 294.13 ms 399.49 ms 105.36 ms
27d7cf8 306.76 ms 366.66 ms 59.90 ms

App size

Revision Plain With Sentry Diff
b77456b 1.58 MiB 2.12 MiB 548.11 KiB
d217708 1.58 MiB 2.10 MiB 532.97 KiB
abf451a 1.58 MiB 2.20 MiB 635.29 KiB
d15471f 1.58 MiB 2.13 MiB 559.54 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
fc5ccaf 1.58 MiB 2.13 MiB 557.54 KiB
d5a29b6 1.58 MiB 2.12 MiB 549.37 KiB
1edbdfa 1.58 MiB 2.20 MiB 635.34 KiB
d15471f 1.58 MiB 2.13 MiB 559.54 KiB
27d7cf8 1.58 MiB 2.12 MiB 549.42 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

User attributes for logs should be guarded by sendDefaultPii

3 participants