-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix(node): Preserve CallbackManager handlers in LangChain instrumentation #20849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
andreiborza
merged 20 commits into
getsentry:develop
from
mdnanocom:fix/langchain-callbackmanager-preservation
May 22, 2026
+149
−102
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
e2b872a
fix(node): Preserve CallbackManager handlers in LangChain instrumenta…
mdnanocom 4c74bfa
test(node): Add unit tests + changelog for LangChain callback fix
mdnanocom b33352b
fix(node): Defensively check inheritableHandlers in LangChain dedupe
mdnanocom 9e2939d
refactor(core): Consolidate LangChain callback merging into mergeSent…
mdnanocom 7dcdd93
review: Tighten CallbackManager detection + drop changelog entry
mdnanocom fb95ad5
Merge remote-tracking branch 'origin/develop' into fix/langchain-call…
mdnanocom 5657854
Merge branch 'develop' into fix/langchain-callbackmanager-preservation
mdnanocom 7333d66
Merge branch 'develop' into fix/langchain-callbackmanager-preservation
mdnanocom d88c503
Merge branch 'develop' into fix/langchain-callbackmanager-preservation
mdnanocom 5e5627a
review: Address andreiborza review on PR #20849
mdnanocom cde3b58
Merge branch 'develop' into fix/langchain-callbackmanager-preservation
mdnanocom 6f36bd1
review: Skip copy when manager already contains the sentry handler
mdnanocom 6bb5463
fix(langchain): Use renamed `_INTERNAL_mergeLangChainCallbackHandler`
mdnanocom 745b9e1
Merge branch 'develop' into fix/langchain-callbackmanager-preservation
mdnanocom 315373d
Merge branch 'develop' into fix/langchain-callbackmanager-preservation
mdnanocom 45b7a05
Merge branch 'develop' into fix/langchain-callbackmanager-preservation
mdnanocom 926b4bc
Simplify logic
andreiborza 2704ffd
Merge branch 'develop' into fix/langchain-callbackmanager-preservation
mdnanocom ea874b9
Check for existing SentryCallbackHandler via name property instead of…
andreiborza fb9f575
Ensure lone handlers are handled correctly
andreiborza File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.