Skip to content

feat(core): Migrate span streaming envelope to dataCollection#21080

Merged
chargome merged 3 commits into
developfrom
cg/spans-datacollection
May 21, 2026
Merged

feat(core): Migrate span streaming envelope to dataCollection#21080
chargome merged 3 commits into
developfrom
cg/spans-datacollection

Conversation

@chargome
Copy link
Copy Markdown
Member

@chargome chargome commented May 20, 2026

Switch to reading from dataCollection.userInfo instead of sendDefaultPii

closes #21079

@chargome chargome self-assigned this May 20, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 20, 2026

size-limit report 📦

Path Size % Change Change
@sentry/browser 27.31 kB - -
@sentry/browser - with treeshaking flags 25.73 kB - -
@sentry/browser (incl. Tracing) 45.31 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 47.54 kB +0.03% +11 B 🔺
@sentry/browser (incl. Tracing, Profiling) 50.29 kB - -
@sentry/browser (incl. Tracing, Replay) 84.91 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 74.42 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 89.63 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 102.23 kB - -
@sentry/browser (incl. Feedback) 44.5 kB - -
@sentry/browser (incl. sendFeedback) 32.12 kB - -
@sentry/browser (incl. FeedbackAsync) 37.24 kB - -
@sentry/browser (incl. Metrics) 28.39 kB - -
@sentry/browser (incl. Logs) 28.62 kB - -
@sentry/browser (incl. Metrics & Logs) 29.32 kB - -
@sentry/react 29.04 kB - -
@sentry/react (incl. Tracing) 47.54 kB - -
@sentry/vue 32.23 kB - -
@sentry/vue (incl. Tracing) 47.16 kB - -
@sentry/svelte 27.34 kB - -
CDN Bundle 29.71 kB - -
CDN Bundle (incl. Tracing) 47.83 kB +0.02% +6 B 🔺
CDN Bundle (incl. Logs, Metrics) 31.2 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 49.08 kB +0.02% +6 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) 70.52 kB - -
CDN Bundle (incl. Tracing, Replay) 85.33 kB +0.01% +7 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 86.49 kB +0.01% +6 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 91.2 kB +0.02% +14 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 92.36 kB +0.04% +32 B 🔺
CDN Bundle - uncompressed 87.78 kB - -
CDN Bundle (incl. Tracing) - uncompressed 144.27 kB +0.02% +21 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed 92.27 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 148.03 kB +0.02% +21 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 217 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 263.05 kB +0.01% +21 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 266.79 kB +0.01% +21 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 276.75 kB +0.01% +21 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 280.48 kB +0.01% +21 B 🔺
@sentry/nextjs (client) 50.02 kB - -
@sentry/sveltekit (client) 45.79 kB - -
@sentry/core/server 76.31 kB +0.02% +12 B 🔺
@sentry/core/browser 63.07 kB +0.02% +9 B 🔺
@sentry/node-core 62.58 kB +0.03% +17 B 🔺
@sentry/node 164.33 kB +0.02% +17 B 🔺
@sentry/node - without tracing 75.01 kB +0.03% +15 B 🔺
@sentry/aws-serverless 87.23 kB +0.02% +15 B 🔺
@sentry/cloudflare (withSentry) - minified 172.98 kB +0.02% +21 B 🔺
@sentry/cloudflare (withSentry) 432.15 kB +0.01% +20 B 🔺

View base workflow run

@chargome
Copy link
Copy Markdown
Member Author

@cursor review

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 273d94a. Configure here.

@chargome chargome marked this pull request as ready for review May 20, 2026 15:55
@chargome chargome requested review from nicohrubec and s1gr1d May 20, 2026 15:55
Copy link
Copy Markdown
Member

@nicohrubec nicohrubec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment thread packages/core/test/lib/tracing/spans/envelope.test.ts
@chargome chargome enabled auto-merge (squash) May 21, 2026 08:48
@chargome chargome merged commit 52db40c into develop May 21, 2026
262 of 263 checks passed
@chargome chargome deleted the cg/spans-datacollection branch May 21, 2026 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate span envelope to dataCollection

2 participants