ref(logs): allow different log level types #1992
Open
+157
−97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Litarnus
commented
Jan 13, 2026
| } | ||
|
|
||
| public static function logLevelDataProvider(): iterable | ||
| public static function monologLegacyLevelDataProvider(): iterable |
Contributor
Author
There was a problem hiding this comment.
The tests are maybe a bit too verbose and confusing, not sure
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| return $record['level'] >= $this->logLevel->value; | ||
| } else { | ||
| return $record['level'] >= $this->logLevel; | ||
| } |
There was a problem hiding this comment.
Enum-to-int comparison fails in Monolog 3
High Severity
In Monolog 3, $record['level'] returns a \Monolog\Level enum object, not an integer. The comparisons on lines 59 and 61 attempt to compare this enum directly with integer values ($this->logLevel->value or $this->logLevel), which throws a TypeError in PHP 8.1+ since backed enums cannot be compared with integers using >=. The BreadcrumbHandler in the same codebase demonstrates the correct pattern: checking if ($level instanceof Level) and extracting $level->value before comparison.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the possible log level to properly handle the filtering of log messages.
Since sentry has fewer log levels than monolog, it wasn't possible to filter based on monolog levels because we would convert it losing some levels. With the changes in this PR, it will be possible to filter based on monolog levels and the severity will only be converted when sending to sentry.