feat(span-first): Support before_send_span#6239
Conversation
before_send_span
Codecov Results 📊✅ 67 passed | Total: 67 | Pass Rate: 100% | Execution Time: 9.51s 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ❌ Patch coverage is 63.04%. Project has 14264 uncovered lines. Files with missing lines (6)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 35.16% 35.35% +0.19%
==========================================
Files 190 190 —
Lines 22039 22064 +25
Branches 7408 7420 +12
==========================================
+ Hits 7748 7800 +52
- Misses 14291 14264 -27
- Partials 717 717 —Generated by Codecov Action |
Codecov Results 📊✅ 44 passed | ❌ 13 failed | Total: 57 | Pass Rate: 77.19% | Execution Time: 9.62s ❌ Failed Tests
|
| File | Patch % | Lines |
|---|---|---|
utils.py |
54.32% | |
client.py |
61.82% | |
consts.py |
99.22% |
Generated by Codecov Action
Description
Add support for
before_send_spanin span streaming mode.before_send_spanis different frombefore_send_metricandbefore_send_login that:None)To that end, we're now serializing the span earlier, and exposing the serialized dictionary in the
before_sendcallback. This is consistent with metrics and logs. It also means we're now queuing dictionaries instead ofStreamedSpaninstances in the span batcher, which should also decrease our memory footprint.See https://develop.sentry.dev/sdk/telemetry/spans/scrubbing-data/ for spec.
Issues
before_send_span#5388