-
-
Notifications
You must be signed in to change notification settings - Fork 357
chore(android): Increase Android diffMax to 5.5 MB #5542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(android): Increase Android diffMax to 5.5 MB #5542
Conversation
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR will not appear in the changelog. 🤖 This preview updates automatically when you update the PR. |
alwx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am wondering if we could increase it even more because otherwise it will likely break again once the new native SDKs are released. But that also works for now.
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e0efebc+dirty | 334.33 ms | 337.59 ms | 3.27 ms |
| 0886964 | 420.28 ms | 435.74 ms | 15.46 ms |
| 1edd908+dirty | 409.44 ms | 423.54 ms | 14.10 ms |
| b3d7080+dirty | 360.17 ms | 366.32 ms | 6.15 ms |
| 5c2b683+dirty | 444.54 ms | 455.27 ms | 10.72 ms |
| 8ad3a67+dirty | 423.68 ms | 469.96 ms | 46.28 ms |
| c555a21+dirty | 409.55 ms | 448.36 ms | 38.81 ms |
| fa62e21 | 432.46 ms | 457.29 ms | 24.83 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e0efebc+dirty | 17.75 MiB | 19.75 MiB | 2.00 MiB |
| 0886964 | 17.75 MiB | 19.72 MiB | 1.97 MiB |
| 1edd908+dirty | 43.75 MiB | 48.04 MiB | 4.29 MiB |
| b3d7080+dirty | 17.75 MiB | 19.74 MiB | 1.99 MiB |
| 5c2b683+dirty | 43.75 MiB | 48.04 MiB | 4.29 MiB |
| 8ad3a67+dirty | 43.75 MiB | 48.02 MiB | 4.27 MiB |
| c555a21+dirty | 43.75 MiB | 48.07 MiB | 4.32 MiB |
| fa62e21 | 17.75 MiB | 19.68 MiB | 1.94 MiB |
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e0efebc+dirty | 354.72 ms | 393.98 ms | 39.26 ms |
| fa62e21+dirty | 366.25 ms | 422.43 ms | 56.18 ms |
| 0886964+dirty | 327.26 ms | 380.80 ms | 53.54 ms |
| 1edd908+dirty | 410.21 ms | 429.31 ms | 19.09 ms |
| b3d7080+dirty | 363.00 ms | 369.73 ms | 6.73 ms |
| 5c2b683+dirty | 428.37 ms | 443.18 ms | 14.81 ms |
| 8ad3a67+dirty | 582.11 ms | 624.33 ms | 42.21 ms |
| c555a21+dirty | 407.55 ms | 437.13 ms | 29.57 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e0efebc+dirty | 7.15 MiB | 8.46 MiB | 1.31 MiB |
| fa62e21+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| 0886964+dirty | 7.15 MiB | 8.45 MiB | 1.29 MiB |
| 1edd908+dirty | 43.94 MiB | 48.87 MiB | 4.93 MiB |
| b3d7080+dirty | 7.15 MiB | 8.46 MiB | 1.30 MiB |
| 5c2b683+dirty | 43.94 MiB | 48.87 MiB | 4.93 MiB |
| 8ad3a67+dirty | 43.94 MiB | 48.85 MiB | 4.91 MiB |
| c555a21+dirty | 43.94 MiB | 48.90 MiB | 4.96 MiB |
Good point. I was thinking of bumping it to 6 directly but a 0.5 increase seems big already. We can bump it again when the test fails and keep track of the change. |
d95cefa
into
deps/scripts/update-android.sh
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8ad3a67+dirty | 1218.04 ms | 1216.00 ms | -2.04 ms |
| e0efebc+dirty | 1242.81 ms | 1244.18 ms | 1.37 ms |
| c555a21+dirty | 1207.72 ms | 1212.40 ms | 4.68 ms |
| 1edd908+dirty | 1215.00 ms | 1210.58 ms | -4.42 ms |
| b3d7080+dirty | 1219.02 ms | 1229.04 ms | 10.02 ms |
| fa62e21+dirty | 1238.14 ms | 1244.73 ms | 6.59 ms |
| 0886964+dirty | 1231.23 ms | 1235.18 ms | 3.95 ms |
| 5c2b683+dirty | 1214.09 ms | 1212.23 ms | -1.86 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8ad3a67+dirty | 3.41 MiB | 4.58 MiB | 1.17 MiB |
| e0efebc+dirty | 2.63 MiB | 4.01 MiB | 1.38 MiB |
| c555a21+dirty | 3.41 MiB | 4.66 MiB | 1.25 MiB |
| 1edd908+dirty | 3.41 MiB | 4.59 MiB | 1.18 MiB |
| b3d7080+dirty | 2.63 MiB | 4.00 MiB | 1.37 MiB |
| fa62e21+dirty | 2.63 MiB | 3.91 MiB | 1.28 MiB |
| 0886964+dirty | 2.63 MiB | 3.91 MiB | 1.28 MiB |
| 5c2b683+dirty | 3.41 MiB | 4.59 MiB | 1.18 MiB |
* chore: update scripts/update-android.sh to 8.30.0 * chore(deps): update Android SDK Stubs to v8.30.0 (#5540) * chore: update scripts/update-android-stubs.sh to 8.30.0 * Update stub --------- Co-authored-by: GitHub <[email protected]> Co-authored-by: Antonis Lilis <[email protected]> * chore(android): Increase Android diffMax to 5.5 MB (#5542) --------- Co-authored-by: GitHub <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Antonis Lilis <[email protected]>
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8ad3a67+dirty | 1217.57 ms | 1220.02 ms | 2.45 ms |
| e0efebc+dirty | 1231.80 ms | 1248.38 ms | 16.58 ms |
| c555a21+dirty | 1212.74 ms | 1217.23 ms | 4.49 ms |
| 1edd908+dirty | 1217.83 ms | 1218.65 ms | 0.82 ms |
| b3d7080+dirty | 1232.59 ms | 1228.77 ms | -3.83 ms |
| fa62e21+dirty | 1220.90 ms | 1216.46 ms | -4.44 ms |
| 0886964+dirty | 1221.41 ms | 1218.40 ms | -3.01 ms |
| 5c2b683+dirty | 1220.20 ms | 1218.85 ms | -1.35 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8ad3a67+dirty | 3.41 MiB | 4.58 MiB | 1.17 MiB |
| e0efebc+dirty | 3.19 MiB | 4.58 MiB | 1.39 MiB |
| c555a21+dirty | 3.41 MiB | 4.66 MiB | 1.25 MiB |
| 1edd908+dirty | 3.41 MiB | 4.59 MiB | 1.18 MiB |
| b3d7080+dirty | 3.19 MiB | 4.57 MiB | 1.38 MiB |
| fa62e21+dirty | 3.19 MiB | 4.48 MiB | 1.29 MiB |
| 0886964+dirty | 3.19 MiB | 4.48 MiB | 1.29 MiB |
| 5c2b683+dirty | 3.41 MiB | 4.59 MiB | 1.18 MiB |
📢 Type of change
📜 Description
Updated the threshold to 5.5 MiB. This will pass since the actual difference is 5.44 MiB, and it provides a tighter limit with a small buffer (~62 KB) for minor fluctuations.
💡 Motivation and Context
Opened a separate PR to keep track of the change since the binary size check failed in the 8.30.0 Android bump
💚 How did you test it?
CI
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps
#skip-changelog