ref(dashboards): convert generic widget queries to functional component #106182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
static/app/views/dashboards/widgetCard/genericWidgetQueries.tsx
Outdated
Show resolved
Hide resolved
static/app/views/dashboards/widgetCard/genericWidgetQueries.tsx
Outdated
Show resolved
Hide resolved
static/app/views/dashboards/widgetCard/genericWidgetQueries.tsx
Outdated
Show resolved
Hide resolved
static/app/views/dashboards/widgetCard/genericWidgetQueries.tsx
Outdated
Show resolved
Hide resolved
- Fix stale `selection` prop in `transformTable` call by reading from `latestPropsRef` - Fix stale `dashboardFilters` in `applyDashboardFilters` by reading from `latestPropsRef` - Remove setting `queryFetchIDRef` to undefined which caused race condition with active fetches - Refactor queue to use `fetchDataRef` instead of passing function directly - Change deduplication to be based on `fetchDataRef` identity instead of `widgetId` - This solves the remount issue where a new component instance would be blocked by an old queued request - Each component instance now has its own `fetchDataRef`, enabling proper per-instance deduplication - Add `skipDashboardFilterParens` to `latestPropsRef` to avoid stale closure - Remove unnecessary eslint-disable directive These changes address the stale closure bugs identified in PR review comments where widgets would fetch or display data using outdated props when filters changed while requests were queued.
Reset `queryFetchIDRef.current` to undefined when adding a fetch to the queue. This prevents a race condition where an active (not queued) fetch could complete with stale data after props change, briefly displaying incorrect results before the newly queued fetch with updated props executes. Matches the behavior of the original class component implementation.
DominikB2014
deleted the
dominikbuszowiecki/browse-238-convert-generic-widget-queries-to-a-functional-component
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings us closer to supporting
useQueryin dashboards. I tried to do everything with as minimum changes as possible to avoid any regressions.