Skip to content

fix(dashboards): Hide legend alias option for details widget type#112957

Merged
DominikB2014 merged 2 commits intomasterfrom
dominikbuszowiecki/hide-legend-alias-details-widget
Apr 16, 2026
Merged

fix(dashboards): Hide legend alias option for details widget type#112957
DominikB2014 merged 2 commits intomasterfrom
dominikbuszowiecki/hide-legend-alias-details-widget

Conversation

@DominikB2014
Copy link
Copy Markdown
Contributor

Hide the legend alias input in the query filter builder when the details
widget type is selected. The details widget displays data as key-value
pairs with a single query, so a legend alias serves no purpose — similar
to tables and big numbers which are already excluded.

Adds a test confirming the alias input is not rendered for details widgets.

@github-actions github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Apr 14, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@DominikB2014 DominikB2014 marked this pull request as ready for review April 14, 2026 18:56
@DominikB2014 DominikB2014 requested review from a team as code owners April 14, 2026 18:56
@DominikB2014 DominikB2014 marked this pull request as draft April 14, 2026 18:57
@sentry
Copy link
Copy Markdown
Contributor

sentry bot commented Apr 14, 2026

Sentry Snapshot Testing

Name Added Removed Modified Renamed Unchanged Status
sentry-frontend
sentry-frontend
0 0 0 0 204 ✅ Unchanged

Comment thread static/app/chartcuterie/types.tsx
Comment thread static/app/chartcuterie/types.tsx
The details widget displays data as key-value pairs with a single
query, so a legend alias serves no purpose. Add it to the exclusion
list alongside tables, big numbers, and categorical bars.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@DominikB2014 DominikB2014 force-pushed the dominikbuszowiecki/hide-legend-alias-details-widget branch from a9f8c5d to b358c11 Compare April 14, 2026 19:45
Copy link
Copy Markdown
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit b358c11. Configure here.

The details widget only supports a single query (the state reducer
already slices to one on switch), but the "+ Add Filter" button was
still rendering. Add DETAILS to the canAddSearchConditions exclusion
list, consistent with TABLE and BIG_NUMBER.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@DominikB2014 DominikB2014 marked this pull request as ready for review April 16, 2026 13:10
@DominikB2014 DominikB2014 merged commit b4a6ed5 into master Apr 16, 2026
65 checks passed
@DominikB2014 DominikB2014 deleted the dominikbuszowiecki/hide-legend-alias-details-widget branch April 16, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants