ref(span consumer): Use new reference to transaction name#116646
Draft
lobsterkatie wants to merge 2 commits into
Draft
ref(span consumer): Use new reference to transaction name#116646lobsterkatie wants to merge 2 commits into
lobsterkatie wants to merge 2 commits into
Conversation
Contributor
Backend Test FailuresFailures on
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In our Sentry Conventions repo,
sentry.transactionis marked as deprecated in favor ofsentry.segment.namefor the new span schema. The latter should always be there, via one of three routes (either in Relay or an SDK):For transaction-derived spans, it's pulled from
event.transactionand added onto the spans during normalization.For OTel spans, it's copied from the span's
nameinotel_to_sentry_span.For newstyle spans which come from SDKs, it should be there because it's put there by the SDK itself.
(In the case of the two Relay functions, careful readers will note that what's being set is
segment_name, notsegment.name. That conversion happens during serialization because of the metastructure annotation on thesegment_namefield in theSpanDatastruct.)In my work switching issue detectors to be span-buffer-compatible, I came across three spots (two in code, one in a test) where we're still using the old attribute name. This PR updates them to use the new names.
h/t Claude for his help with the research here