Open
Conversation
lindseywild
reviewed
Mar 11, 2026
| @@ -0,0 +1,32 @@ | |||
| export default async function test({ page, addFinding, url } = {}) { | |||
Contributor
There was a problem hiding this comment.
Is there a reason this isn't a .ts file?
lindseywild
reviewed
Mar 11, 2026
- restructure findForUrl code to accound for upcoming changes
lindseywild
reviewed
Mar 11, 2026
Contributor
lindseywild
left a comment
lindseywild
left a comment
There was a problem hiding this comment.
Apologies for all the grammar/docs nits!
I also think we are waiting on two additional items:
- How to make sure screenshots are captured if the input is turned on,
- Allowing users to include JS or TS files and updating docs as needed
After that, this looks good!
- pr feedback changes - add options arg to 'addFinding' function
abdulahmad307
force-pushed
the
abdul/test-plugins
branch
from
deee5be to
d75e16e
Compare
- add scans input to top level action.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a very minimal proof of concept around the idea of using plugins to make additional scans and tests modular. Looking for feedback on general approach, pros/cons, etc...
this currently works with the plugins defined in the scanner repo. I'm still working on making this work with plugins defined in the workflow repo (the repo that uses the action). There might be some issues with using absolute paths with the dynamic import() feature - but i'm still testing.
I've taken @lindseywild’s reflow test and added it as a plugin for testing. the idea is each plugin lives under a new folder under the scanner-plugins folder (which lives under .github like actions). and each plugin has a primary index.js file, which we will use to interface with the plugin.
all of this is just how I've built it as a proposal - we can tweak naming/folder-structure, etc... if we feel something else makes more sense