-
Notifications
You must be signed in to change notification settings - Fork 76
Add Banned8, Banned5, and Banned6 #1094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jeongsoolee09
wants to merge
10
commits into
main
Choose a base branch
from
jeongsoolee09/MISRA-C++-2023-Banned856
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+932
−101
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
6fda6fa
Add Banned8
jeongsoolee09 cd095be
Add Banned5
jeongsoolee09 e4b4e4b
Add Banned6 and improve `@description` metadata of A9-5-1
jeongsoolee09 25c9df8
Fix an editing mistake on rules.csv
jeongsoolee09 e682b81
Fix query formatting
jeongsoolee09 cfaccb3
Re-generate package files with new names and add shared test that was…
jeongsoolee09 52b590b
Fill in shared query file for BannedSyntax and Banned6
jeongsoolee09 895ffbb
Populate shared query for Banned5 / Representation and make shared te…
jeongsoolee09 a54f56d
Minor formatting
jeongsoolee09 e76a2d2
Fix query formatting
jeongsoolee09 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
25 changes: 25 additions & 0 deletions
25
cpp/autosar/src/rules/A9-5-1/UnionKeywordUsedAutosarCpp.ql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| /** | ||
| * @id cpp/autosar/union-keyword-used-autosar-cpp | ||
| * @name A9-5-1: Unions shall not be used | ||
| * @description Unions shall not be used. Tagged unions can be used if 'std::variant' is not | ||
| * available. | ||
| * @kind problem | ||
| * @precision very-high | ||
| * @problem.severity error | ||
| * @tags external/autosar/id/a9-5-1 | ||
| * correctness | ||
| * scope/single-translation-unit | ||
| * external/autosar/allocated-target/implementation | ||
| * external/autosar/enforcement/automated | ||
| * external/autosar/obligation/required | ||
| */ | ||
|
|
||
| import cpp | ||
| import codingstandards.cpp.autosar | ||
| import codingstandards.cpp.rules.unionkeywordused.UnionKeywordUsed | ||
|
|
||
| module UnionKeywordUsedAutosarCppConfig implements UnionKeywordUsedConfigSig { | ||
| Query getQuery() { result = BannedSyntaxPackage::unionKeywordUsedAutosarCppQuery() } | ||
| } | ||
|
|
||
| import UnionKeywordUsed<UnionKeywordUsedAutosarCppConfig> | ||
This file was deleted.
Oops, something went wrong.
35 changes: 0 additions & 35 deletions
35
.../BitFieldsShallBeUsedOnlyWhenInterfacingToHardwareOrConformingToCommunicationProtocols.ql
This file was deleted.
Oops, something went wrong.
28 changes: 28 additions & 0 deletions
28
cpp/autosar/src/rules/A9-6-2/BitFieldsShouldNotBeDeclaredAutosarCpp.ql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| /** | ||
| * @id cpp/autosar/bit-fields-should-not-be-declared-autosar-cpp | ||
| * @name A9-6-2: Bit-fields shall be used only when interfacing to hardware or conforming to communication protocols | ||
| * @description The usage of bit-fields increases code complexity and certain aspects of bit-field | ||
| * manipulation can be error prone and implementation defined. Hence a bit-field usage | ||
| * is reserved only when interfacing to hardware or conformance to communication | ||
| * protocols. | ||
| * @kind problem | ||
| * @precision very-high | ||
| * @problem.severity recommendation | ||
| * @tags external/autosar/id/a9-6-2 | ||
| * maintainability | ||
| * external/autosar/allocated-target/design | ||
| * external/autosar/enforcement/partially-automated | ||
| * external/autosar/obligation/required | ||
| */ | ||
|
|
||
| import cpp | ||
| import codingstandards.cpp.autosar | ||
| import codingstandards.cpp.rules.bitfieldsshallbeusedonlywheninterfacingtohardwareorconformingtocommunicationprotocols.BitFieldsShallBeUsedOnlyWhenInterfacingToHardwareOrConformingToCommunicationProtocols | ||
|
|
||
| module BitFieldsShouldNotBeDeclaredAutosarCppConfig implements | ||
| BitFieldsShallBeUsedOnlyWhenInterfacingToHardwareOrConformingToCommunicationProtocolsConfigSig | ||
| { | ||
| Query getQuery() { result = RepresentationPackage::bitFieldsShouldNotBeDeclaredAutosarCppQuery() } | ||
| } | ||
|
|
||
| import BitFieldsShallBeUsedOnlyWhenInterfacingToHardwareOrConformingToCommunicationProtocols<BitFieldsShouldNotBeDeclaredAutosarCppConfig> |
1 change: 1 addition & 0 deletions
1
cpp/autosar/test/rules/A9-5-1/UnionKeywordUsedAutosarCpp.testref
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| cpp/common/test/rules/unionkeywordused/UnionKeywordUsed.ql |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| cpp/common/test/rules/unionkeywordused/UnionKeywordUsed.ql |
1 change: 0 additions & 1 deletion
1
...eldsShallBeUsedOnlyWhenInterfacingToHardwareOrConformingToCommunicationProtocols.expected
This file was deleted.
Oops, something went wrong.
1 change: 0 additions & 1 deletion
1
...tFieldsShallBeUsedOnlyWhenInterfacingToHardwareOrConformingToCommunicationProtocols.qlref
This file was deleted.
Oops, something went wrong.
1 change: 1 addition & 0 deletions
1
cpp/autosar/test/rules/A9-6-2/BitFieldsShouldNotBeDeclaredAutosarCpp.testref
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| cpp/common/test/rules/bitfieldsshallbeusedonlywheninterfacingtohardwareorconformingtocommunicationprotocols/BitFieldsShallBeUsedOnlyWhenInterfacingToHardwareOrConformingToCommunicationProtocols.ql |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR replaces existing AUTOSAR queries (including changing/removing previous
@ids) rather than only adding new queries. That changes the released artifacts layout, so a change note should be added underchange_notes/(per docs/development_handbook.md) and the PR checklist updated accordingly.