Open
Conversation
andersfugmann
previously approved these changes
Mar 12, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Disables Swift SIL stack protection in the extractor to work around Linux crashes during extraction.
Changes:
- Turns off
swift::SILOptions::EnableStackProtectionin the extractor’s SIL options setup.
Comments suppressed due to low confidence (1)
swift/extractor/main.cpp:84
turnOffSilVerificationsnow also disables stack protection, which is not a verification toggle. Consider moving this setting to a more appropriately named helper (or renaming this function) so future changes don’t accidentally couple unrelated compiler options.
options.VerifyAll = false;
options.VerifyExclusivity = false;
options.VerifyNone = true;
options.VerifySILOwnership = false;
options.EnableStackProtection = false; // Causes crashes on Linux
You can also share your feedback on Copilot code review. Take the survey.
andersfugmann
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although we do not have any Linux testing enabled, this works around crashes we were seeing on Linux with Swift.