Fix golangci-lint failures in CI #44
Merged
+5
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: migue <[email protected]>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions workflow golangci-lint
Fix golangci-lint failures in CI
Jan 12, 2026
migue
merged commit bdc7024
into
copilot/fix-github-actions-workflow-again
4 checks passed
There was a problem hiding this comment.
Pull request overview
This PR fixes 7 golangci-lint violations that were causing CI failures, addressing issues across copyloopvar, revive, and staticcheck linting rules.
Changes:
- Removed obsolete loop variable shadowing patterns (
ex := ex,tc := tc) that are no longer needed with Go 1.22+ per-iteration loop variable scoping - Renamed unused callback and function parameters to
_to satisfy unused parameter linting rules - Simplified
exec.ExitErrorfield access by using the embedded method directly - Added nolint directive for the
FinishEarlysentinel error to preserve the public API naming contract
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pipe/command_test.go | Removed obsolete ex := ex loop variable shadowing |
| pipe/pipeline_test.go | Removed tc := tc shadowing and renamed unused function parameters to _ |
| pipe/pipeline.go | Renamed unused parameter to _ in emptyEventHandler and added nolint directive for FinishEarly sentinel error |
| pipe/command.go | Simplified ExitError field access using embedded Sys() method |
| internal/ptree/ptree_test.go | Renamed unused callback parameter to _ |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The golangci-lint workflow was failing with 7 linting violations across copyloopvar, revive, and staticcheck rules.
Changes
Removed obsolete loop variable copies (Go 1.22+)
pipe/command_test.go,pipe/pipeline_test.go: Deletedex := exandtc := tcshadowing patterns no longer needed with per-iteration loop variable scopingRenamed unused parameters
internal/ptree/ptree_test.go,pipe/pipeline.go,pipe/pipeline_test.go: Changed unused callback/function parameters to_Simplified ExitError field access
pipe/command.go: ChangedeErr.ProcessState.Sys()toeErr.Sys()sinceexec.ExitErrorembeds*os.ProcessStateSuppressed FinishEarly naming lint
pipe/pipeline.go: Added//nolint:staticcheckfor ST1012 on theFinishEarlysentinel error to preserve public API contractOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.