Merged
Conversation
Updated packages: 0.10 (major) 0.10 (major) Fixed breaking changes: - rand 0.10 moved random()/random_range() from Rng to RngExt trait Rng (in rand_core) - rand 0.10 removed RngCore re-export from rand crate rand::make_rng() Supersedes: #100, #101 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the workspace to rand/rand_chacha 0.10 and applies the corresponding API migrations (trait renames, RNG construction helpers) across library code, tests, and benchmarks.
Changes:
- Bump
randandrand_chachafrom 0.9 to 0.10 in affected crates. - Update RNG-related imports and trait bounds to match
rand0.10 (RngExt,rand::make_rng(),rand::Rngfornext_u64()-style APIs). - Adjust test/benchmark code to compile against the new
randAPI surface.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| crates/string-offsets/benchmarks/performance.rs | Switches benchmark RNG trait import to RngExt for random_range(). |
| crates/string-offsets/Cargo.toml | Updates dev-dependency versions for rand and rand_chacha. |
| crates/geo_filters/src/evaluation/simulation.rs | Updates rand trait import and replaces StdRng::from_os_rng() with rand::make_rng(). |
| crates/geo_filters/src/distinct_count.rs | Updates test-only RNG trait import to the new rand::Rng (aliased). |
| crates/geo_filters/src/diff_count.rs | Updates RNG trait imports in test-support code and tests for rand/rand_chacha 0.10. |
| crates/geo_filters/src/config/lookup.rs | Updates test-only RNG trait import to the new rand::Rng (aliased). |
| crates/geo_filters/src/config.rs | Updates test-only RNG trait import to the new rand::Rng (aliased). |
| crates/geo_filters/Cargo.toml | Updates optional + dev dependency versions for rand and rand_chacha. |
| crates/bpe/tests/src/lib.rs | Updates tests to use RngExt for random_range(). |
| crates/bpe/tests/Cargo.toml | Updates rand dev-dependency to 0.10. |
| crates/bpe/src/byte_pair_encoding.rs | Migrates rand usage to RngExt and updates the public encode_minimal_dropout bound accordingly. |
| crates/bpe/benchmarks/performance.rs | Updates benchmark RNG usage to RngExt and removes now-unneeded imports. |
| crates/bpe/benchmarks/Cargo.toml | Updates rand benchmark dependency to 0.10. |
| crates/bpe/Cargo.toml | Updates optional rand dependency to 0.10. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
itsibitzi
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
randandrand_chachafrom 0.9 to 0.10 across all workspace crates. Both are major version bumps but the blast radius is limited --randis only used in test helpers, benchmarks, and behind an optional feature flag inbpe.Updated packages
Code changes
rand 0.10 reorganized its trait hierarchy, requiring updates to imports and trait bounds across 8 source files:
random()andrandom_range()moved fromRngto a newRngExttraitRngCoretoRnginrand_coreRngCoreis no longer re-exported from therandcrateStdRng::from_os_rng()was removed in favor ofrand::make_rng()Validation
make lint-- passes (fmt + clippy)make test-- all tests passmake build-- full workspace build succeedsSupersedes #100 and #101.