Skip to content

fix(scripts): encode residual JSON control chars as \uXXXX instead of stripping #1872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mnriem merged 3 commits into from
Mar 18, 2026
+15 −3
Merged

fix(scripts): encode residual JSON control chars as \uXXXX instead of stripping #1872

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
03377a4
fix(scripts): encode residual control chars as \uXXXX instead of stri…
pierluigilenoci Mar 16, 2026
1b7ce3b
fix(scripts): address Copilot review on json_escape control char loop
pierluigilenoci Mar 17, 2026
0b1f005
perf(scripts): use printf -v to avoid subshell in json_escape loop
pierluigilenoci Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions scripts/bash/common.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,9 +171,21 @@ json_escape() {
s="${s//$'\r'/\\r}"
s="${s//$'\b'/\\b}"
s="${s//$'\f'/\\f}"
# Strip remaining control characters (U+0000–U+001F) not individually escaped above
s=$(printf '%s' "$s" | tr -d '\000-\007\013\016-\037')
printf '%s' "$s"
# Escape any remaining U+0001-U+001F control characters as \uXXXX.
# (U+0000/NUL cannot appear in bash strings and is excluded.)
# LC_ALL=C ensures ${#s} counts bytes and ${s:$i:1} yields single bytes,
# so multi-byte UTF-8 sequences (first byte >= 0xC0) pass through intact.
local LC_ALL=C
local i char code
for (( i=0; i<${#s}; i++ )); do
char="${s:$i:1}"
printf -v code '%d' "'$char" 2>/dev/null || code=256
if (( code >= 1 && code <= 31 )); then
printf '\\u%04x' "$code"
else
printf '%s' "$char"
fi
done
}

check_file() { [[ -f "$1" ]] && echo " ✓ $2" || echo " ✗ $2"; }
Expand Down
Loading