Swarming: Adds dynamic Job specific bot dimensions#5199
Merged
Conversation
IvanBM18
added
the
swarming
jardondiego
reviewed
Mar 10, 2026
| return local_config.SwarmingConfig() | ||
|
|
||
|
|
||
| def _get_task_dimensions(job: data_types.Job, platform_specific_dimensions: list |
Collaborator
There was a problem hiding this comment.
It's great to have type hints!
jardondiego
reviewed
Mar 10, 2026
javanlacerda
approved these changes
Mar 17, 2026
Collaborator
javanlacerda
left a comment
javanlacerda
left a comment
There was a problem hiding this comment.
LGTM. I'm approving it to avoid missing this work, but the further PRs against master should be towards the integration with the remote task interface. go/cf-swarming-integration-agreement
Collaborator
|
There are some conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In an effort to gradually add swarming integration changes back. This PR adds the ability to set dynamic job dimensions in addition to the static config platform specific dimensions for swarming tasks.
The dimensions will be added trough the job env_string with the following syntax:
The Job specific dimensions will have more presedence than that the static config ones, which will allows us to have more flexibility when sending swarming tasks.
Also adds two unit tests to handle the new test cases
Bug: b/483772015