feat: Remove Google App Engine standard support#4152
Open
stevehipwell wants to merge 2 commits intogoogle:masterfrom
Open
feat: Remove Google App Engine standard support#4152stevehipwell wants to merge 2 commits intogoogle:masterfrom
stevehipwell wants to merge 2 commits intogoogle:masterfrom
Conversation
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
This was referenced Apr 14, 2026
gmlewis
changed the title
gmlewis
added
NeedsReview
gmlewis
changed the title
gmlewis
removed
the
Breaking API Change
gmlewis
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4152 +/- ##
==========================================
+ Coverage 93.76% 93.83% +0.07%
==========================================
Files 211 209 -2
Lines 19701 19685 -16
==========================================
Hits 18472 18472
+ Misses 1031 1015 -16
Partials 198 198 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmlewis
approved these changes
Apr 14, 2026
Collaborator
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @stevehipwell.
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
cc: @alexandear - @zyfy29 - @Not-Dhananjay-Mishra - @munlicode
Not-Dhananjay-Mishra
approved these changes
Apr 14, 2026
Contributor
Not-Dhananjay-Mishra
left a comment
Not-Dhananjay-Mishra
left a comment
There was a problem hiding this comment.
LGTM. Just one small question
Comment on lines
+1876
to
+1880
|
|
||
| // withContext returns a shallow copy of req with its context changed to ctx. | ||
| func withContext(ctx context.Context, req *http.Request) *http.Request { | ||
| return req.WithContext(ctx) | ||
| } |
Contributor
There was a problem hiding this comment.
Why do we need this helper function? Why can’t we directly use req.WithContext(ctx) where needed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes support for Google App Engine Classic (Go < 1.12) including removing the
appenginebuild tag.This change is required for #4151.