Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ module(
bazel_dep(name = "platforms", version = "1.0.0")
bazel_dep(name = "bazel_skylib", version = "1.9.0")
bazel_dep(name = "rules_cc", version = "0.2.14")
bazel_dep(name = "abseil-cpp", version = "20250814.2")
bazel_dep(name = "abseil-cpp", version = "20260107.1")

# For backwards compatibility with WORKSPACE.
# The name "com_google_protobuf" is internally used by @bazel_tools,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ ENV PKG_CONFIG_PATH=/usr/lib/x86_64-linux-gnu/pkgconfig:/usr/local/lib/pkgconfig

# ```bash
WORKDIR /var/tmp/build/abseil-cpp
RUN curl -fsSL https://github.com/abseil/abseil-cpp/archive/20250814.2.tar.gz | \
RUN curl -fsSL https://github.com/abseil/abseil-cpp/archive/20260107.1.tar.gz | \
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Abseil version "20260107.1" is hardcoded in this RUN curl command. This version string is duplicated across multiple Dockerfiles. To improve maintainability, consider defining this version as an ARG at the top of the Dockerfile and referencing it here.

References
  1. In Dockerfiles, use ARG to define version strings that are duplicated across multiple files to improve maintainability.

tar -xzf - --strip-components=1 && \
cmake \
-DCMAKE_BUILD_TYPE=Debug \
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ RUN curl -fsSL https://github.com/Kitware/cmake/archive/v3.22.3.tar.gz | \

# ```bash
WORKDIR /var/tmp/build/abseil-cpp
RUN curl -fsSL https://github.com/abseil/abseil-cpp/archive/20250814.2.tar.gz | \
RUN curl -fsSL https://github.com/abseil/abseil-cpp/archive/20260107.1.tar.gz | \
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Abseil version "20260107.1" is hardcoded in this RUN curl command. This version string is duplicated across multiple Dockerfiles. To improve maintainability, consider defining this version as an ARG at the top of the Dockerfile and referencing it here.

References
  1. In Dockerfiles, use ARG to define version strings that are duplicated across multiple files to improve maintainability.

tar -xzf - --strip-components=1 && \
cmake \
-DCMAKE_BUILD_TYPE=Debug \
Expand Down
2 changes: 1 addition & 1 deletion ci/cloudbuild/dockerfiles/demo-opensuse-leap.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ ENV CXX=g++-9

# ```bash
WORKDIR /var/tmp/build/abseil-cpp
RUN curl -fsSL https://github.com/abseil/abseil-cpp/archive/20250814.2.tar.gz | \
RUN curl -fsSL https://github.com/abseil/abseil-cpp/archive/20260107.1.tar.gz | \
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Abseil version "20260107.1" is hardcoded in this RUN curl command. This version string is duplicated across multiple Dockerfiles. To improve maintainability, consider defining this version as an ARG at the top of the Dockerfile and referencing it here.

References
  1. In Dockerfiles, use ARG to define version strings that are duplicated across multiple files to improve maintainability.

tar -xzf - --strip-components=1 && \
cmake \
-DCMAKE_BUILD_TYPE=Debug \
Expand Down
2 changes: 1 addition & 1 deletion ci/cloudbuild/dockerfiles/demo-rockylinux-9.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ ENV PATH=/usr/local/bin:${PATH}

# ```bash
WORKDIR /var/tmp/build/abseil-cpp
RUN curl -fsSL https://github.com/abseil/abseil-cpp/archive/20250814.2.tar.gz | \
RUN curl -fsSL https://github.com/abseil/abseil-cpp/archive/20260107.1.tar.gz | \
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Abseil version "20260107.1" is hardcoded in this RUN curl command. This version string is duplicated across multiple Dockerfiles. To improve maintainability, consider defining this version as an ARG at the top of the Dockerfile and referencing it here.

References
  1. In Dockerfiles, use ARG to define version strings that are duplicated across multiple files to improve maintainability.

tar -xzf - --strip-components=1 && \
cmake \
-DCMAKE_BUILD_TYPE=Debug \
Expand Down
2 changes: 1 addition & 1 deletion ci/cloudbuild/dockerfiles/demo-ubuntu-24.04.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ RUN ln -s /usr/bin/pkgconf /usr/bin/pkg-config

# ```bash
WORKDIR /var/tmp/build/abseil-cpp
RUN curl -fsSL https://github.com/abseil/abseil-cpp/archive/20250814.2.tar.gz | \
RUN curl -fsSL https://github.com/abseil/abseil-cpp/archive/20260107.1.tar.gz | \
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Abseil version "20260107.1" is hardcoded in this RUN curl command. This version string is duplicated across multiple Dockerfiles. To improve maintainability, consider defining this version as an ARG at the top of the Dockerfile and referencing it here.

References
  1. In Dockerfiles, use ARG to define version strings that are duplicated across multiple files to improve maintainability.

tar -xzf - --strip-components=1 && \
cmake \
-DCMAKE_BUILD_TYPE=Debug \
Expand Down
2 changes: 1 addition & 1 deletion ci/cloudbuild/dockerfiles/demo-ubuntu-jammy.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ RUN apt-get update && \

# ```bash
WORKDIR /var/tmp/build/abseil-cpp
RUN curl -fsSL https://github.com/abseil/abseil-cpp/archive/20250814.2.tar.gz | \
RUN curl -fsSL https://github.com/abseil/abseil-cpp/archive/20260107.1.tar.gz | \
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Abseil version "20260107.1" is hardcoded in this RUN curl command. This version string is duplicated across multiple Dockerfiles. To improve maintainability, consider defining this version as an ARG at the top of the Dockerfile and referencing it here.

References
  1. In Dockerfiles, use ARG to define version strings that are duplicated across multiple files to improve maintainability.

tar -xzf - --strip-components=1 && \
cmake \
-DCMAKE_BUILD_TYPE=Debug \
Expand Down
2 changes: 1 addition & 1 deletion ci/cloudbuild/dockerfiles/fedora-latest-cmake.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ ENV PKG_CONFIG_PATH=/usr/local/lib64/pkgconfig:/usr/local/lib/pkgconfig:/usr/lib
# We disable the inline namespace because otherwise Abseil LTS updates break our
# `check-api` build.
WORKDIR /var/tmp/build
RUN curl -fsSL https://github.com/abseil/abseil-cpp/archive/20250814.2.tar.gz | \
RUN curl -fsSL https://github.com/abseil/abseil-cpp/archive/20260107.1.tar.gz | \
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Abseil version "20260107.1" is hardcoded in this RUN curl command. This version string is duplicated across multiple Dockerfiles. To improve maintainability, consider defining this version as an ARG at the top of the Dockerfile and referencing it here.

References
  1. In Dockerfiles, use ARG to define version strings that are duplicated across multiple files to improve maintainability.

tar -xzf - --strip-components=1 && \
cmake \
-DCMAKE_BUILD_TYPE="Release" \
Expand Down
2 changes: 1 addition & 1 deletion ci/cloudbuild/dockerfiles/fedora-latest-cxx20.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ ENV PKG_CONFIG_PATH=/usr/local/lib64/pkgconfig:/usr/local/lib/pkgconfig:/usr/lib
# with fewer layers).

WORKDIR /var/tmp/build
RUN curl -fsSL https://github.com/abseil/abseil-cpp/archive/20250814.2.tar.gz | \
RUN curl -fsSL https://github.com/abseil/abseil-cpp/archive/20260107.1.tar.gz | \
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Abseil version "20260107.1" is hardcoded in this RUN curl command. This version string is duplicated across multiple Dockerfiles. To improve maintainability, consider defining this version as an ARG at the top of the Dockerfile and referencing it here.

References
  1. In Dockerfiles, use ARG to define version strings that are duplicated across multiple files to improve maintainability.

tar -xzf - --strip-components=1 && \
cmake \
-DCMAKE_CXX_STANDARD=20 \
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ RUN apt update && apt install -y openjdk-13-jre
# image smaller (and with fewer layers)

WORKDIR /var/tmp/build/abseil-cpp
RUN curl -fsSL https://github.com/abseil/abseil-cpp/archive/20250814.2.tar.gz | \
RUN curl -fsSL https://github.com/abseil/abseil-cpp/archive/20260107.1.tar.gz | \
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Abseil version "20260107.1" is hardcoded in this RUN curl command. This version string is duplicated across multiple Dockerfiles. To improve maintainability, consider defining this version as an ARG at the top of the Dockerfile and referencing it here.

References
  1. In Dockerfiles, use ARG to define version strings that are duplicated across multiple files to improve maintainability.

tar -xzf - --strip-components=1 && \
cmake \
-DCMAKE_BUILD_TYPE="Release" \
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ RUN apt update && apt install -y openjdk-11-jre
# image smaller (and with fewer layers)

WORKDIR /var/tmp/build/abseil-cpp
RUN curl -fsSL https://github.com/abseil/abseil-cpp/archive/20250814.2.tar.gz | \
RUN curl -fsSL https://github.com/abseil/abseil-cpp/archive/20260107.1.tar.gz | \
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Abseil version "20260107.1" is hardcoded in this RUN curl command. This version string is duplicated across multiple Dockerfiles. To improve maintainability, consider defining this version as an ARG at the top of the Dockerfile and referencing it here.

References
  1. In Dockerfiles, use ARG to define version strings that are duplicated across multiple files to improve maintainability.

tar -xzf - --strip-components=1 && \
cmake \
-DCMAKE_BUILD_TYPE="Release" \
Expand Down
12 changes: 6 additions & 6 deletions doc/packaging.md
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@ export CC=gcc-9 export CXX=g++-9

```bash
mkdir -p $HOME/Downloads/abseil-cpp && cd $HOME/Downloads/abseil-cpp
curl -fsSL https://github.com/abseil/abseil-cpp/archive/20250814.2.tar.gz | \
curl -fsSL https://github.com/abseil/abseil-cpp/archive/20260107.1.tar.gz | \
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Abseil version "20260107.1" is hardcoded here and duplicated in other sections of this document. While not a Dockerfile, the principle of avoiding hardcoded duplicated values applies to documentation as well to improve maintainability. Consider using a common reference or variable if the markdown syntax allows for it, to avoid repetition.

tar -xzf - --strip-components=1 && \
cmake \
-DCMAKE_BUILD_TYPE=Debug \
Expand Down Expand Up @@ -536,7 +536,7 @@ ln -s /usr/bin/pkgconf /usr/bin/pkg-config

```bash
mkdir -p $HOME/Downloads/abseil-cpp && cd $HOME/Downloads/abseil-cpp
curl -fsSL https://github.com/abseil/abseil-cpp/archive/20250814.2.tar.gz | \
curl -fsSL https://github.com/abseil/abseil-cpp/archive/20260107.1.tar.gz | \
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Abseil version "20260107.1" is hardcoded here and duplicated in other sections of this document. While not a Dockerfile, the principle of avoiding hardcoded duplicated values applies to documentation as well to improve maintainability. Consider using a common reference or variable if the markdown syntax allows for it, to avoid repetition.

tar -xzf - --strip-components=1 && \
cmake \
-DCMAKE_BUILD_TYPE=Debug \
Expand Down Expand Up @@ -677,7 +677,7 @@ sudo apt-get --no-install-recommends install -y apt-transport-https apt-utils \

```bash
mkdir -p $HOME/Downloads/abseil-cpp && cd $HOME/Downloads/abseil-cpp
curl -fsSL https://github.com/abseil/abseil-cpp/archive/20250814.2.tar.gz | \
curl -fsSL https://github.com/abseil/abseil-cpp/archive/20260107.1.tar.gz | \
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Abseil version "20260107.1" is hardcoded here and duplicated in other sections of this document. While not a Dockerfile, the principle of avoiding hardcoded duplicated values applies to documentation as well to improve maintainability. Consider using a common reference or variable if the markdown syntax allows for it, to avoid repetition.

tar -xzf - --strip-components=1 && \
cmake \
-DCMAKE_BUILD_TYPE=Debug \
Expand Down Expand Up @@ -847,7 +847,7 @@ export PKG_CONFIG_PATH=/usr/lib/x86_64-linux-gnu/pkgconfig:/usr/local/lib/pkgcon

```bash
mkdir -p $HOME/Downloads/abseil-cpp && cd $HOME/Downloads/abseil-cpp
curl -fsSL https://github.com/abseil/abseil-cpp/archive/20250814.2.tar.gz | \
curl -fsSL https://github.com/abseil/abseil-cpp/archive/20260107.1.tar.gz | \
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Abseil version "20260107.1" is hardcoded here and duplicated in other sections of this document. While not a Dockerfile, the principle of avoiding hardcoded duplicated values applies to documentation as well to improve maintainability. Consider using a common reference or variable if the markdown syntax allows for it, to avoid repetition.

tar -xzf - --strip-components=1 && \
cmake \
-DCMAKE_BUILD_TYPE=Debug \
Expand Down Expand Up @@ -997,7 +997,7 @@ tar -xzf - --strip-components=1 && \

```bash
mkdir -p $HOME/Downloads/abseil-cpp && cd $HOME/Downloads/abseil-cpp
curl -fsSL https://github.com/abseil/abseil-cpp/archive/20250814.2.tar.gz | \
curl -fsSL https://github.com/abseil/abseil-cpp/archive/20260107.1.tar.gz | \
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Abseil version "20260107.1" is hardcoded here and duplicated in other sections of this document. While not a Dockerfile, the principle of avoiding hardcoded duplicated values applies to documentation as well to improve maintainability. Consider using a common reference or variable if the markdown syntax allows for it, to avoid repetition.

tar -xzf - --strip-components=1 && \
cmake \
-DCMAKE_BUILD_TYPE=Debug \
Expand Down Expand Up @@ -1185,7 +1185,7 @@ export PATH=/usr/local/bin:${PATH}

```bash
mkdir -p $HOME/Downloads/abseil-cpp && cd $HOME/Downloads/abseil-cpp
curl -fsSL https://github.com/abseil/abseil-cpp/archive/20250814.2.tar.gz | \
curl -fsSL https://github.com/abseil/abseil-cpp/archive/20260107.1.tar.gz | \
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Abseil version "20260107.1" is hardcoded here and duplicated in other sections of this document. While not a Dockerfile, the principle of avoiding hardcoded duplicated values applies to documentation as well to improve maintainability. Consider using a common reference or variable if the markdown syntax allows for it, to avoid repetition.

tar -xzf - --strip-components=1 && \
cmake \
-DCMAKE_BUILD_TYPE=Debug \
Expand Down
Loading