-
Notifications
You must be signed in to change notification settings - Fork 442
chore: update abseil to 20260107.1 #16054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -37,7 +37,7 @@ RUN curl -fsSL https://github.com/Kitware/cmake/archive/v3.22.3.tar.gz | \ | |
|
|
||
| # ```bash | ||
| WORKDIR /var/tmp/build/abseil-cpp | ||
| RUN curl -fsSL https://github.com/abseil/abseil-cpp/archive/20250814.2.tar.gz | \ | ||
| RUN curl -fsSL https://github.com/abseil/abseil-cpp/archive/20260107.1.tar.gz | \ | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The Abseil version "20260107.1" is hardcoded in this References
|
||
| tar -xzf - --strip-components=1 && \ | ||
| cmake \ | ||
| -DCMAKE_BUILD_TYPE=Debug \ | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -58,7 +58,7 @@ ENV CXX=g++-9 | |
|
|
||
| # ```bash | ||
| WORKDIR /var/tmp/build/abseil-cpp | ||
| RUN curl -fsSL https://github.com/abseil/abseil-cpp/archive/20250814.2.tar.gz | \ | ||
| RUN curl -fsSL https://github.com/abseil/abseil-cpp/archive/20260107.1.tar.gz | \ | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The Abseil version "20260107.1" is hardcoded in this References
|
||
| tar -xzf - --strip-components=1 && \ | ||
| cmake \ | ||
| -DCMAKE_BUILD_TYPE=Debug \ | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -72,7 +72,7 @@ ENV PATH=/usr/local/bin:${PATH} | |
|
|
||
| # ```bash | ||
| WORKDIR /var/tmp/build/abseil-cpp | ||
| RUN curl -fsSL https://github.com/abseil/abseil-cpp/archive/20250814.2.tar.gz | \ | ||
| RUN curl -fsSL https://github.com/abseil/abseil-cpp/archive/20260107.1.tar.gz | \ | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The Abseil version "20260107.1" is hardcoded in this References
|
||
| tar -xzf - --strip-components=1 && \ | ||
| cmake \ | ||
| -DCMAKE_BUILD_TYPE=Debug \ | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -63,7 +63,7 @@ RUN ln -s /usr/bin/pkgconf /usr/bin/pkg-config | |
|
|
||
| # ```bash | ||
| WORKDIR /var/tmp/build/abseil-cpp | ||
| RUN curl -fsSL https://github.com/abseil/abseil-cpp/archive/20250814.2.tar.gz | \ | ||
| RUN curl -fsSL https://github.com/abseil/abseil-cpp/archive/20260107.1.tar.gz | \ | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The Abseil version "20260107.1" is hardcoded in this References
|
||
| tar -xzf - --strip-components=1 && \ | ||
| cmake \ | ||
| -DCMAKE_BUILD_TYPE=Debug \ | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -32,7 +32,7 @@ RUN apt-get update && \ | |
|
|
||
| # ```bash | ||
| WORKDIR /var/tmp/build/abseil-cpp | ||
| RUN curl -fsSL https://github.com/abseil/abseil-cpp/archive/20250814.2.tar.gz | \ | ||
| RUN curl -fsSL https://github.com/abseil/abseil-cpp/archive/20260107.1.tar.gz | \ | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The Abseil version "20260107.1" is hardcoded in this References
|
||
| tar -xzf - --strip-components=1 && \ | ||
| cmake \ | ||
| -DCMAKE_BUILD_TYPE=Debug \ | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -84,7 +84,7 @@ ENV PKG_CONFIG_PATH=/usr/local/lib64/pkgconfig:/usr/local/lib/pkgconfig:/usr/lib | |
| # We disable the inline namespace because otherwise Abseil LTS updates break our | ||
| # `check-api` build. | ||
| WORKDIR /var/tmp/build | ||
| RUN curl -fsSL https://github.com/abseil/abseil-cpp/archive/20250814.2.tar.gz | \ | ||
| RUN curl -fsSL https://github.com/abseil/abseil-cpp/archive/20260107.1.tar.gz | \ | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The Abseil version "20260107.1" is hardcoded in this References
|
||
| tar -xzf - --strip-components=1 && \ | ||
| cmake \ | ||
| -DCMAKE_BUILD_TYPE="Release" \ | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -73,7 +73,7 @@ ENV PKG_CONFIG_PATH=/usr/local/lib64/pkgconfig:/usr/local/lib/pkgconfig:/usr/lib | |
| # with fewer layers). | ||
|
|
||
| WORKDIR /var/tmp/build | ||
| RUN curl -fsSL https://github.com/abseil/abseil-cpp/archive/20250814.2.tar.gz | \ | ||
| RUN curl -fsSL https://github.com/abseil/abseil-cpp/archive/20260107.1.tar.gz | \ | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The Abseil version "20260107.1" is hardcoded in this References
|
||
| tar -xzf - --strip-components=1 && \ | ||
| cmake \ | ||
| -DCMAKE_CXX_STANDARD=20 \ | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -59,7 +59,7 @@ RUN apt update && apt install -y openjdk-13-jre | |
| # image smaller (and with fewer layers) | ||
|
|
||
| WORKDIR /var/tmp/build/abseil-cpp | ||
| RUN curl -fsSL https://github.com/abseil/abseil-cpp/archive/20250814.2.tar.gz | \ | ||
| RUN curl -fsSL https://github.com/abseil/abseil-cpp/archive/20260107.1.tar.gz | \ | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The Abseil version "20260107.1" is hardcoded in this References
|
||
| tar -xzf - --strip-components=1 && \ | ||
| cmake \ | ||
| -DCMAKE_BUILD_TYPE="Release" \ | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -58,7 +58,7 @@ RUN apt update && apt install -y openjdk-11-jre | |
| # image smaller (and with fewer layers) | ||
|
|
||
| WORKDIR /var/tmp/build/abseil-cpp | ||
| RUN curl -fsSL https://github.com/abseil/abseil-cpp/archive/20250814.2.tar.gz | \ | ||
| RUN curl -fsSL https://github.com/abseil/abseil-cpp/archive/20260107.1.tar.gz | \ | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The Abseil version "20260107.1" is hardcoded in this References
|
||
| tar -xzf - --strip-components=1 && \ | ||
| cmake \ | ||
| -DCMAKE_BUILD_TYPE="Release" \ | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -361,7 +361,7 @@ export CC=gcc-9 export CXX=g++-9 | |
|
|
||
| ```bash | ||
| mkdir -p $HOME/Downloads/abseil-cpp && cd $HOME/Downloads/abseil-cpp | ||
| curl -fsSL https://github.com/abseil/abseil-cpp/archive/20250814.2.tar.gz | \ | ||
| curl -fsSL https://github.com/abseil/abseil-cpp/archive/20260107.1.tar.gz | \ | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The Abseil version "20260107.1" is hardcoded here and duplicated in other sections of this document. While not a Dockerfile, the principle of avoiding hardcoded duplicated values applies to documentation as well to improve maintainability. Consider using a common reference or variable if the markdown syntax allows for it, to avoid repetition. |
||
| tar -xzf - --strip-components=1 && \ | ||
| cmake \ | ||
| -DCMAKE_BUILD_TYPE=Debug \ | ||
|
|
@@ -536,7 +536,7 @@ ln -s /usr/bin/pkgconf /usr/bin/pkg-config | |
|
|
||
| ```bash | ||
| mkdir -p $HOME/Downloads/abseil-cpp && cd $HOME/Downloads/abseil-cpp | ||
| curl -fsSL https://github.com/abseil/abseil-cpp/archive/20250814.2.tar.gz | \ | ||
| curl -fsSL https://github.com/abseil/abseil-cpp/archive/20260107.1.tar.gz | \ | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The Abseil version "20260107.1" is hardcoded here and duplicated in other sections of this document. While not a Dockerfile, the principle of avoiding hardcoded duplicated values applies to documentation as well to improve maintainability. Consider using a common reference or variable if the markdown syntax allows for it, to avoid repetition. |
||
| tar -xzf - --strip-components=1 && \ | ||
| cmake \ | ||
| -DCMAKE_BUILD_TYPE=Debug \ | ||
|
|
@@ -677,7 +677,7 @@ sudo apt-get --no-install-recommends install -y apt-transport-https apt-utils \ | |
|
|
||
| ```bash | ||
| mkdir -p $HOME/Downloads/abseil-cpp && cd $HOME/Downloads/abseil-cpp | ||
| curl -fsSL https://github.com/abseil/abseil-cpp/archive/20250814.2.tar.gz | \ | ||
| curl -fsSL https://github.com/abseil/abseil-cpp/archive/20260107.1.tar.gz | \ | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The Abseil version "20260107.1" is hardcoded here and duplicated in other sections of this document. While not a Dockerfile, the principle of avoiding hardcoded duplicated values applies to documentation as well to improve maintainability. Consider using a common reference or variable if the markdown syntax allows for it, to avoid repetition. |
||
| tar -xzf - --strip-components=1 && \ | ||
| cmake \ | ||
| -DCMAKE_BUILD_TYPE=Debug \ | ||
|
|
@@ -847,7 +847,7 @@ export PKG_CONFIG_PATH=/usr/lib/x86_64-linux-gnu/pkgconfig:/usr/local/lib/pkgcon | |
|
|
||
| ```bash | ||
| mkdir -p $HOME/Downloads/abseil-cpp && cd $HOME/Downloads/abseil-cpp | ||
| curl -fsSL https://github.com/abseil/abseil-cpp/archive/20250814.2.tar.gz | \ | ||
| curl -fsSL https://github.com/abseil/abseil-cpp/archive/20260107.1.tar.gz | \ | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The Abseil version "20260107.1" is hardcoded here and duplicated in other sections of this document. While not a Dockerfile, the principle of avoiding hardcoded duplicated values applies to documentation as well to improve maintainability. Consider using a common reference or variable if the markdown syntax allows for it, to avoid repetition. |
||
| tar -xzf - --strip-components=1 && \ | ||
| cmake \ | ||
| -DCMAKE_BUILD_TYPE=Debug \ | ||
|
|
@@ -997,7 +997,7 @@ tar -xzf - --strip-components=1 && \ | |
|
|
||
| ```bash | ||
| mkdir -p $HOME/Downloads/abseil-cpp && cd $HOME/Downloads/abseil-cpp | ||
| curl -fsSL https://github.com/abseil/abseil-cpp/archive/20250814.2.tar.gz | \ | ||
| curl -fsSL https://github.com/abseil/abseil-cpp/archive/20260107.1.tar.gz | \ | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The Abseil version "20260107.1" is hardcoded here and duplicated in other sections of this document. While not a Dockerfile, the principle of avoiding hardcoded duplicated values applies to documentation as well to improve maintainability. Consider using a common reference or variable if the markdown syntax allows for it, to avoid repetition. |
||
| tar -xzf - --strip-components=1 && \ | ||
| cmake \ | ||
| -DCMAKE_BUILD_TYPE=Debug \ | ||
|
|
@@ -1185,7 +1185,7 @@ export PATH=/usr/local/bin:${PATH} | |
|
|
||
| ```bash | ||
| mkdir -p $HOME/Downloads/abseil-cpp && cd $HOME/Downloads/abseil-cpp | ||
| curl -fsSL https://github.com/abseil/abseil-cpp/archive/20250814.2.tar.gz | \ | ||
| curl -fsSL https://github.com/abseil/abseil-cpp/archive/20260107.1.tar.gz | \ | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The Abseil version "20260107.1" is hardcoded here and duplicated in other sections of this document. While not a Dockerfile, the principle of avoiding hardcoded duplicated values applies to documentation as well to improve maintainability. Consider using a common reference or variable if the markdown syntax allows for it, to avoid repetition. |
||
| tar -xzf - --strip-components=1 && \ | ||
| cmake \ | ||
| -DCMAKE_BUILD_TYPE=Debug \ | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Abseil version "20260107.1" is hardcoded in this
RUN curlcommand. This version string is duplicated across multiple Dockerfiles. To improve maintainability, consider defining this version as anARGat the top of the Dockerfile and referencing it here.References
ARGto define version strings that are duplicated across multiple files to improve maintainability.