Conversation
- Fix wrong subcommand: `generate` -> `add-new-library` (confirmed via GitHub workflow) - Replace Cloud Drop references with Buganizer ticket as the sole input source - Add conflict-checking step before script execution - Add special cases table for google/maps/* and google/shopping/* APIs - Add branch/PR creation step with owlbot:run label guidance - Expand generation_config_schema.md with all optional fields from the script - Update cloud_drop_mapping.md framing to remove Cloud Drop terminology
…ibrary-generation-skill
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new skill for generating Google Cloud Java client libraries, including comprehensive documentation on the workflow, configuration schema, and service YAML mapping. The review feedback identifies several inconsistencies across the documentation files regarding script names, directory paths, and CLI flag naming conventions. Additionally, the reviewer pointed out a typo in a Maven group ID and recommended replacing hardcoded user paths in example outputs with generic placeholders.
.agents/skills/new-client-library-generator/references/generation_guide.md
Outdated
Show resolved
Hide resolved
.agents/skills/new-client-library-generator/references/generation_guide.md
Outdated
Show resolved
Hide resolved
.agents/skills/new-client-library-generator/references/generation_guide.md
Outdated
Show resolved
Hide resolved
.agents/skills/new-client-library-generator/references/generation_guide.md
Outdated
Show resolved
Hide resolved
.agents/skills/new-client-library-generator/references/generation_guide.md
Outdated
Show resolved
Hide resolved
.agents/skills/new-client-library-generator/references/generation_guide.md
Show resolved
Hide resolved
.agents/skills/new-client-library-generator/references/generation_guide.md
Outdated
Show resolved
Hide resolved
.agents/skills/new-client-library-generator/references/generation_guide.md
Outdated
Show resolved
Hide resolved
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
blakeli0
left a comment
blakeli0
left a comment
There was a problem hiding this comment.
Looks good overall. Please note that Librarian may change how we generate new client in the next few months.
.agents/skills/new-client-library-generator/references/generation_guide.md
Outdated
Show resolved
Hide resolved
.agents/skills/new-client-library-generator/references/generation_guide.md
Outdated
Show resolved
Hide resolved
.agents/skills/new-client-library-generator/references/service_yaml_mapping.md
Show resolved
Hide resolved
…ion_guide.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sounds good. We can remove this skill whenever needed. |
2 participants
Trying out a new agent skill for new library generation requests. Uses internal MCP tools and skills to pull the relevant information.
This should allow workflows where we can prompt gemini for
Generate a new library for b/XXXXXInterestingly, this PR uses AI to generate commands to tell AI how to automatically generate a library request