Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the enablegRPCMetrics method in SpannerOptions to check if built-in metrics are enabled before proceeding, and adds a unit test to verify that gRPC metrics are skipped when built-in metrics are disabled. The reviewer suggested renaming enablegRPCMetrics to enableGrpcMetrics to better align with Java camelCase naming conventions.
java-spanner/google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerOptions.java
Show resolved
Hide resolved
sakthivelmanii
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #12229
setBuiltInMetricsEnabled(false) was only disabling the Spanner API tracer metrics path. During channel setup, the client could still install gRPC built-in metrics/export wiring and create the Cloud Monitoring exporter. In practice, users could
still see SpannerCloudMonitoringExporter attempts and monitoring.timeSeries.create permission failures even though startup logs reported:
That behavior contradicted the documented contract that setBuiltInMetricsEnabled(false) opts out of client-side metrics.