feat(bqjdbc): Add custom logger to handle ResultSet logs#13034
Open
feat(bqjdbc): Add custom logger to handle ResultSet logs#13034
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces BigQueryJdbcResultSetLogger, a specialized high-performance logger designed for ResultSet and related classes to avoid expensive stack trace walking on hot paths. It updates various JDBC classes to use this new logger and its finestTrace method. Feedback highlights a potential memory leak in the logger's static cache when using connection IDs, a bug where the log method override destructively overwrites existing log parameters, and an opportunity to further optimize performance by overriding the fine logging methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b/510827966
Optimized JDBC driver performance by implementing a custom logger for ResultSet classes, designed for low impact when logging is off and efficient handling when on.
Lazy Logging Overloads: Added Java 8 Supplier overloads to custom loggers, eliminating dynamic string allocations and GC pressure when logging is disabled.
Explicit Trace Logging: Introduced Supplier-based trace overloads (like finestTrace) with explicit method parameters, bypassing CPU-intensive stack-walking.
ResultSet-Wide Refactoring: Refactored 11 ResultSet-related classes to use these lazy trace overloads, removing hot-path logging overhead at the bytecode level.
Per-Connection Log Routing: Enhanced PerConnectionFileHandler to extract connection IDs directly from log parameters, preventing log leakage into the global log.