chore(spanner): add missing commit ts logging#13036
Open
skuruppu wants to merge 1 commit intogoogleapis:mainfrom
Open
chore(spanner): add missing commit ts logging#13036skuruppu wants to merge 1 commit intogoogleapis:mainfrom
skuruppu wants to merge 1 commit intogoogleapis:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request enhances error reporting and logging in TransactionRunnerImpl.java when a commitTimestamp is missing, specifically tracking precommit tokens and retry attempts. However, the current implementation contains several API usage errors where span.addAnnotation and txnLogger.log are called with multiple string arguments instead of a single concatenated string, which will cause compilation or logging failures.
If the commit timestamp is missing from a commit response, it would be good to have more visibility into the state of the commit by looking at whether it's in the commit-retry phase or not.
skuruppu
force-pushed
the
spanner-empty-commit-ts-logging
branch
from
914c3e2 to
cb9aceb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the commit timestamp is missing from a commit response, we can have more visibility into the state of the commit by looking at whether it's in the commit-retry phase or not.